-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XUnit test for HandleDoubleAndSingleQuote
in CompletionHelpers class
#25181
Add XUnit test for HandleDoubleAndSingleQuote
in CompletionHelpers class
#25181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to add only TestHandleDoubleAndSingleQuote tests in the PR. I have many questions for rest.
HandleDoubleAndSingleQuote
in CompletionHelpers class
All good @iSazonov. I have only included test for |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I suggest to move tests for QuoteCompletionText and GetMatchingResults to other PRs. If we add QuoteCompletionText the tests should be in that PR. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@iSazonov Looks like unrelated packaging failures for Windows CI. Might need a rerun. Not sure though if this can auto merge with PSResourceGet and CodeFactor issues. |
📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
So to make sure the
HandleDoubleAndSingleQuote
method in CompletionHelpers class is covered from regression, I have added tests to ensure code is covered by regressions.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).