Skip to content

added new approved Build and Deploy verbs #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2017

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Aug 31, 2017

Fix #3346

removed suggestions that these were not valid

organized verbs to be in alphabetical order to make it easier to compare against
(unfortunately, the diff viewer on GitHub isn't so smart about lines that were moved, easier to review the individual commits)
https://msdn.microsoft.com/en-us/library/ms714428(VS.85).aspx

Created doc bug to update above link MicrosoftDocs/PowerShell-Docs#1630

Copy link
Contributor

@markekraus markekraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some info

@@ -348,6 +348,11 @@ public static class VerbsLifecycle
public const string Assert = "Assert";

/// <summary>
/// Creates an artifact (usually a binary or ) out of some set of input files (usually source code or declarative documents)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(usually a binary or ) Missing info after 'or'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

@SteveL-MSFT
Copy link
Member Author

@markekraus can you Approve if you're ok with the changes? Thanks!

@SteveL-MSFT SteveL-MSFT assigned daxian-dbw and unassigned lzybkr Sep 1, 2017
@daxian-dbw daxian-dbw merged commit 2f34009 into PowerShell:master Sep 2, 2017
@SteveL-MSFT SteveL-MSFT deleted the devops-verbs branch September 2, 2017 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants