Fix Delay Test Race Condition #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-run count: I
markekraus
force-pushed
the
FixDelayTests
branch
from
d89d97c to
d10e13c
Compare
SteveL-MSFT
requested changes
Oct 6, 2017
| @@ -551,7 +551,7 @@ Describe "Invoke-WebRequest tests" -Tags "Feature" { | |||
| It "Validate Invoke-WebRequest error with -Proxy option set - '<name>'" -TestCases $testCase { | |||
| param($proxy_address, $name, $protocol) | |||
|
|
|||
| $uri = Get-WebListenerUrl -Test 'Delay' -TestValue '5' -Https:$($protocol -eq 'https') | |||
| $uri = Get-WebListenerUrl -Test 'Delay' -TestValue '6' -Https:$($protocol -eq 'https') | |||
| $command = "Invoke-WebRequest -Uri '$uri' -TimeoutSec 5 -Proxy '${proxy_address}' -SkipCertificateCheck" | |||
There was a problem hiding this comment.
Since it appears that this test expects a timeout to happen, should we make timeoutsec less? like 2 seconds?
There was a problem hiding this comment.
@SteveL-MSFT I'm good with that. I will modify your previous change as well so they are all on the same settings. Are you thinking the -TestValue '5' and the -TimeoutSec 2?
There was a problem hiding this comment.
I think delay of 5 and timeout of 2 makes sense
SteveL-MSFT
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition where WebListener is answering fast enough for the timeout not to trigger. Address CI issues in #4937 expands work from #5005 to other tests.
example: https://travis-ci.org/PowerShell/PowerShell/jobs/284145590