import-module incorrectly reporting a loaded module was not found #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing break after module was loaded successfully so loop continues but module isn't "found" and thus reports error even though loaded
SteveL-MSFT
requested review from
BrucePay,
daxian-dbw and
lzybkr
as code owners
daxian-dbw
approved these changes
Oct 25, 2017
JamesWTruher
suggested changes
Oct 25, 2017
| @@ -27,6 +39,11 @@ | |||
| { $script:module = Import-Module $moduleName -PassThru } | Should Not Throw | |||
There was a problem hiding this comment.
Please add -ErrorAction Stop as a failed load is not a terminating error
|
Shall we add the '[Feature]' tag to run all tests? |
|
@daxian-dbw it wouldn't hurt to run [feature] tests, will update |
|
@daxian-dbw looks like for mac Travis-CI installed beta.8, but the scripts tried to start pwsh. Did we publish beta.9 to homebrew already? |
|
@SteveL-MSFT The PR to update powershell.beta.9 in homebrew is here: Homebrew/homebrew-cask#40043 @adityapatwardhan submitted the PR early this morning, but it hasn't been merged yet. |
|
@daxian-dbw thanks, I guess we'll just wait for that to merged then I'll restart the macOS job |
|
@SteveL-MSFT restarted the Travis-CI macOS job. The homebrew PR is merged. |
|
@JamesWTruher can you re-review? |
JamesWTruher
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing break after module was loaded successfully so loop continues
but module isn't "found" and thus reports error even though loaded
Fix #5232