Skip to content

Fix for #6880 Progress panel displays incorrectly on UNIX when the user is typing. #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Fix for #6880 Progress panel displays incorrectly on UNIX when the user is typing. #6972

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a88bf33
Added code to SetBufferContents() so that, on UNIX, it repositions th…
Jun 1, 2018
9b282d3
Merge branch 'master' of https://github.com/powershell/powershell int…
Jun 1, 2018
cdde309
removed blank line
Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostRawUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,7 +1741,7 @@ public override void SetBufferContents(Coordinates origin,
{
PSTraceSource.NewArgumentNullException("contents");
}

Copy link
Collaborator

@iSazonov iSazonov Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the extra change.

//if the cursor is on the last line, we need to make more space to print the specified buffer
if (origin.Y == BufferSize.Height - 1 && origin.X >= BufferSize.Width)
{
Expand All @@ -1756,6 +1756,14 @@ public override void SetBufferContents(Coordinates origin,
}
}

#if UNIX
// Make sure that the physical cursor position matches where we think it is.
// This is a problem on *nix, because input that the user types is echoed
// and that moves the cursor. As a consequence, the cursor needs to be repositioned
// before we update the screen.
CursorPosition = origin;
#endif

//iterate through the buffer to set
foreach (var charitem in contents)
{
Expand Down