Skip to content

Update help content for TabCompletion tests only if it does not exist #8355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 29, 2018

PR Summary

The TabCompletion tests need help content to be present. Currently we update the help in user scope if it does not exists. The help content could be in all users scope and would be found by tab completion.

The change also checks for help content in All Users scope.

PR Checklist

@adityapatwardhan
Copy link
Member Author

@JamesWTruher Pushed a change. Please have a look.

Copy link
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adityapatwardhan adityapatwardhan merged commit 8c3de33 into PowerShell:master Nov 30, 2018
@adityapatwardhan adityapatwardhan deleted the FixTabCompletionHelpTest branch November 30, 2018 00:16
@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Test Indicates that a PR should be marked as a test change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants