-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add -RepeatHeader
to Format-Table
to enable repeating header for each screen full
#8481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daxian-dbw
merged 7 commits into
PowerShell:master
from
SteveL-MSFT:format-table-header
Dec 20, 2018
Merged
Add -RepeatHeader
to Format-Table
to enable repeating header for each screen full
#8481
daxian-dbw
merged 7 commits into
PowerShell:master
from
SteveL-MSFT:format-table-header
Dec 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
4b4f8b3
to
efe8124
Compare
The remaining codefactor issues are not related to this PR or I'm adopting the current conventions in the source code for consistency but breaks CodeFactor rules. |
1073566
to
38c5f8e
Compare
38c5f8e
to
3fc6463
Compare
PaulHigin
suggested changes
Dec 18, 2018
src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/BaseOutputtingCommand.cs
Outdated
Show resolved
Hide resolved
daxian-dbw
requested changes
Dec 19, 2018
src/System.Management.Automation/FormatAndOutput/common/BaseOutputtingCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/BaseOutputtingCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/BaseOutputtingCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/TableWriter.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/TableWriter.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/FormatAndOutput/common/TableWriter.cs
Outdated
Show resolved
Hide resolved
PaulHigin
approved these changes
Dec 19, 2018
Propose a different way to organize the code
daxian-dbw
approved these changes
Dec 19, 2018
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When using a screen reader or just getting the output of a table with lots of rows, the header is no longer on the screen and the columns may no longer make sense without the context. This PR adds a
-RepeatHeader
switch toFormat-Table
to enable re-outputting the header after every screen full (minus 1 row). Expectation is that the user is piping the output to a pager (e.g. less) which uses the bottom row for pager information. I followed theAutoSize
parameter as the way to get the parameter from the cmdlet into the deep formatting object where it's needed.Fix #8455
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.-RepeatHeader
switch forFormat-Table
MicrosoftDocs/PowerShell-Docs#3443[feature]
if the change is significant or affects feature tests