Skip to content

Make test file result names unique #8979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Feb 25, 2019

PR Summary

Make test file result names unique

  • Also, remove dead code that I found during investigation

Fixes #8978

PR Context

Making the filenames unique, ensures that we can download the results from the artifacts and do our own processing of the results.

PR Checklist

@TravisEz13 TravisEz13 force-pushed the fix_test_result_file_names branch from 002e295 to 1bb1c57 Compare February 25, 2019 19:22
Copy link
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iSazonov
Copy link
Collaborator

CI-windows temporary failed.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 25, 2019
@TravisEz13 TravisEz13 merged commit dc8aed9 into PowerShell:master Feb 25, 2019
@TravisEz13 TravisEz13 deleted the fix_test_result_file_names branch February 25, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsts build seems to be losing results in the TestResults artifact
4 participants