Skip to content

Improve startup sequence of ProtocolServer implementations #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Jan 5, 2016 · 1 comment
Closed

Improve startup sequence of ProtocolServer implementations #106

daviwil opened this issue Jan 5, 2016 · 1 comment
Labels
Issue-Bug A bug to squash.

Comments

@daviwil
Copy link
Contributor

daviwil commented Jan 5, 2016

Currently when the PowerShellContext starts up, it happens before the Logger has been enabled which means that any log messages written at that point won't be visible in the log file. Right now I have to initialize an EditorSession in the constructor of both the LanguageServer and DebugAdapter classes so that things are set up before the channel gets started.

We need to fix the current ProtocolServer startup sequence so that everything happens in the proper order when ProtocolServer.Start is called.
@daviwil daviwil added the Issue-Bug A bug to squash. label Jan 5, 2016
@daviwil daviwil added this to the Backlog milestone Jan 5, 2016
@rjmholt rjmholt mentioned this issue Aug 9, 2018
Closed
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
@daviwil
Fix PowerShell#106: Don't start LanguageClient on non-Win OS
dca434f 
This change causes the LanguageClient class to not be created on
non-Windows OSes (specifically OS X and Linux).  Previously this had not
caused a major issue for users on OS X but it eventually became apparent
that VS Code's default word-based completion engine did not work for OS X
users because we were still registering our completion provider even
though it was not able to execute on that OS.
@TylerLeonhardt
Copy link
Member

I'm just going to close this since we've moved to omnisharp.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Oct 4, 2019
@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daviwil @TylerLeonhardt @SydneyhSmith