Skip to content

Host tests using WaitForEvent calls should include timeouts #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Jan 5, 2016 · 1 comment
Closed

Host tests using WaitForEvent calls should include timeouts #107

daviwil opened this issue Jan 5, 2016 · 1 comment
Labels
Issue-Bug A bug to squash.
Milestone
0.4.0

Comments

@daviwil
Copy link
Contributor

daviwil commented Jan 5, 2016

WaitForEvent methods are a pretty common pattern in host (LanguageServer and DebugAdapter) tests. A timeout needs to be added implementations of this method so that these tests don't hang indefinitely when something goes wrong.
@daviwil daviwil added the Issue-Bug A bug to squash. label Jan 5, 2016
@daviwil daviwil added this to the 0.4.0 milestone Jan 5, 2016
@daviwil
Copy link
Contributor Author

daviwil commented Jan 5, 2016

This could be one potential cause for this issue: #65

daviwil added a commit that referenced this issue Jan 10, 2016
@daviwil
Fix #107: Host tests should have wait timeouts
d7fa930 
This change adds a standard 5 second timeout to language server and debug
adapter tests which wait for events to be returned from the server.  This
will prevent these tests from hanging on the CI server and also will
indicate which events are not being raised as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug A bug to squash.
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@daviwil