Skip to content

Request referenced files from the client instead of attempting to load from the language service #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daviwil opened this issue Mar 10, 2016 · 0 comments
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@daviwil
Copy link
Contributor

daviwil commented Mar 10, 2016

Currently any files that are referenced from an edited script (i.e. dot-source references) are being resolved and loaded by the language service. Since we want to target remote editing scenarios (language service running in a web service), we need to shift the file resolution responsibility to the client so that it can resolve files with respect to its own workspace.

This will require the introduction of new protocol request/response types which allow the server to request files from the client. The core PSES API will handle this behavior through an interface so that file resolver implementations can be chosen at runtime.

This bug in vscode-powershell should benefit from the improvement: PowerShell/vscode-powershell#31

@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Mar 10, 2016
@daviwil daviwil self-assigned this Mar 10, 2016
@daviwil daviwil added this to the 0.6.0 milestone Mar 10, 2016
@daviwil daviwil modified the milestones: 0.7.0, 0.6.0 Apr 25, 2016
@daviwil daviwil modified the milestones: 0.7.0, Backlog Sep 2, 2016
@andyleejordan andyleejordan removed this from the Backlog milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

2 participants