legacy/1.x: Backport #909 to use global.json to pin .Net Core SDK version and update .Net SDK version to be the same as in master (2.1.801) #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
changed the title
bergmeister
commented
Oct 3, 2019
| @@ -34,7 +34,7 @@ if ($PSVersionTable.PSEdition -ne "Core") { | |||
|
|
|||
| task SetupDotNet -Before Clean, Build, TestHost, TestServer, TestProtocol, TestPowerShellApi { | |||
|
|
|||
| $requiredSdkVersion = "2.0.0" | |||
There was a problem hiding this comment.
Note that 2.0 has already reached the end of its life a year ago!
https://dotnet.microsoft.com/download/dotnet-core
rjmholt
approved these changes
Oct 3, 2019
|
It seems changing the SDK from 2.0 to 2.1 breaks the Windows builds in different ways. One of them is that dotnet xunit has been deprecated |
|
@PoshChan please retry |
|
@bergmeister, I do not understand: please retry Commands available in this repo for you:
|
|
@bergmeister I usually just use the checks tab |
|
The legacy branch is an odd one. It targets net451 and netstandard1.3 I believe. It might not be worth making this change. |
TylerLeonhardt
force-pushed
the
legacy/1.x
branch
from
74320f7 to
809d244
Compare
|
#1103 has a lot of this code change in it. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #909 to use global.json to pin .Net Core SDK version and update .Net SDK version to be the same as in master.
This makes the 2 branches not only more consistent but makes building locally easier (I could not build the legacy branch at first yesterday because I have the .Net Core 3 SDK installed)