New colors supported by PS7 (#1064) #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
approved these changes
Oct 31, 2019
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
LGTM (included the Linux test failure root caused to it using .NET Core 3.0 SDK)
SteveL-MSFT
reviewed
Oct 31, 2019
src/PowerShellEditorServices/Session/Host/EditorServicesPSHost.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
reviewed
Oct 31, 2019
SteveL-MSFT
approved these changes
Oct 31, 2019
Member
SteveL-MSFT
left a comment
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Some NITs from doing a bunch of CodeFactor and Codacy fixes
src/PowerShellEditorServices/Session/Host/EditorServicesPSHost.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: Steve Lee <slee@microsoft.com> Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1064.