Remove extra newline in GetComment feature

[TylerLeonhardt]

The ## comment generation feature has started putting a new line between the comment and the function... That doesn't seem right.

This trims that extra newline in PSES.

[TylerLeonhardt]

also removed LINQ :)

[rjmholt]

This is technically less safe; if there are no results we'll crash. But if we know we're going to get a correction that's ok (looks like we make the assumption that the result we get will have an edit, but that is conditioned on Correction being non-null).

Don't know enough about the context above to know whether the assumption is safe.

But the alternative is cheap I suppose:

if (analysisResults == null || analysisResults.Count == 0)
{
    return result;
}

string helpText = analysisResults[0].Correction?.Edits[0].Text;

if (helpText == null)
{
    return result;
}

[rjmholt]

Should this be where result.Content is assigned?

If there's no empty line at the end, it seems we don't assign result.Content.

So maybe instead the way to go is:

if (string.IsNullOrEmpty(helpLines[helpLines.Count - 1]))
{
    helpLines.RemoveAt(helpLines.Count - 1);
}

result.Content = helpLines.ToArray();
return result;

[rjmholt]

GetRange will duplicate the entire list into a new value, leaving two lists on the heap to garbage collect.

It might be better to use RemoveAt:

helpLines.RemoveAt(0);
helpLines.RemoveAt(helpLines.Count - 1);

[TylerLeonhardt]

LGTM