Fixes no prompt showing up #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Nov 11, 2019
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Outdated
Show resolved
Hide resolved
SeeminglyScience
approved these changes
Nov 12, 2019
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
Member
Author
|
just waiting to see if this fixes the issue for the user. It should but I sent them a vsix. |
Member
Author
|
Fixed it for them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PowerShell/vscode-powershell#1850
After reading the code, I realized that this was much simpler than I initially thought. No newline was written when a breakpoint was hit and so no prompt was being written because the cursor position was in the same location.
I'm not sure if this also fixes the mixed output... I don't think it does.