Fix untitled file references #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Feb 3, 2020
| if (!Path.IsPathRooted(filePath)) | ||
| { | ||
| // TODO: Assert instead? | ||
| throw new InvalidOperationException( |
There was a problem hiding this comment.
This can never happen because the client only ever sends AbsoluteUris
There was a problem hiding this comment.
Technically a client that isn't VSCode might do this (just realised this now)
rjmholt
approved these changes
Feb 3, 2020
|
Issues
======
+ Solved 1
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the
ScriptFileconstructor and also fixed an issue where in-memory files wouldn't be able to get CodeLens.I want to get to a point where
DocumentUrion theScriptFileclass is a reference toSystem.Uribut I'm gonna call that out of scope due to time constraints.I believe this change is needed for #1119 as well