Skip to content

ms-vscode.csharp to ms-dotnettools.csharp #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2020
Merged

ms-vscode.csharp to ms-dotnettools.csharp #1223

merged 1 commit into from
Mar 9, 2020

Conversation

@devlead
Copy link
Contributor

@devlead devlead commented Mar 8, 2020

C# extension has changed its name from "ms-vscode.csharp" to "ms-dotnettools.csharp", this means all extensions depending on it needs to be updated and i.e. all repositories with extension.json containing

"recommendations": [
    "ms-vscode.csharp"
 ]

or you get errors like

image

@devlead devlead requested a review from rjmholt as a code owner March 8, 2020 16:06
TylerLeonhardt
TylerLeonhardt approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit 2c67277 into PowerShell:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devlead @TylerLeonhardt @rjmholt