Make ExecuteCommandAsync cancellable
#1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/debugger
branch
from
07df16a to
9b25ad5
Compare
andyleejordan
force-pushed
the
andschwa/debugger
branch
2 times, most recently
from
f284325 to
401c65e
Compare
andyleejordan
changed the title
ExecuteCommandAsync cancellable
andyleejordan
force-pushed
the
andschwa/debugger
branch
2 times, most recently
from
ed56d2f to
b1808f0
Compare
|
@rjmholt The dev build I had several users test and approve for fixing the |
andyleejordan
added
Area-Debugging
Issue-Enhancement
rjmholt
reviewed
Aug 11, 2021
| @@ -137,6 +137,7 @@ public async Task StartAsync() | |||
| public void Dispose() | |||
| { | |||
| _powerShellContextService.IsDebugServerActive = false; | |||
| // TODO: If the debugger has stopped, should we clear the breakpoints? | |||
There was a problem hiding this comment.
As long as they're sent to us fresh in the next session, I think we should yeah
src/PowerShellEditorServices/Services/DebugAdapter/DebugEventHandlerService.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Handlers/LaunchAndAttachHandler.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShellContext/Handlers/ExpandAliasHandler.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs
Show resolved
Hide resolved
...rShellEditorServices/Services/PowerShellContext/Handlers/PSHostProcessAndRunspaceHandlers.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShellContext/Handlers/ShowHelpHandler.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andschwa/debugger
branch
4 times, most recently
from
0b8a4a5 to
98a3bd9
Compare
This lets us cancel the debugger more reliably.
andyleejordan
force-pushed
the
andschwa/debugger
branch
from
98a3bd9 to
6a19daf
Compare
rjmholt
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't solved the problem where the PowerShell debugger and the VS Code debugger somehow disconnect from each other when
System.Windows.Formsis added to the PowerShell session, but it does improve the situation somewhat. The debugger can be stopped now (though it cannot be restarted yet).