Fix debugger regression where console needed input to start/continue #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
These needed to be explicitly `None` to indicate that they should not be cancelled (for various reasons).
This unintentionally introduced a bug with the PSReadLine integration which left users needing to press `ENTER` in the console to start or continue the debugger.
andyleejordan
force-pushed
the
andschwa/cancel-tokens
branch
from
a59629e to
2316a2d
Compare
andyleejordan
changed the title
rjmholt
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These needed to be explicitly
Noneto indicate that they should not be cancelled (for various reasons). The actual bug fix was the removal ofshell.Stop(). Fixes PowerShell/vscode-powershell#3513.