Fix regression with F5 to use . instead of & operator
#1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spoke too soon: testing this interactively shows that it's not the entire solution. |
andyleejordan
force-pushed
the
andschwa/fix-f5-operator
branch
from
eddd981 to
b719512
Compare
This also corrects the scope of the script's parameter variables to be `Local` instead of `Command` in the `DebuggerAcceptsScriptArgs` test, and `Local` instead of `Auto` for most of the rest of the tests (as they were previous to the pipeline work). Excitingly, this even fixes the `DebuggerSetsVariablesNoConversion` test, although `DebuggerSetsVariablesWithConversion` is still broken (for a different reason).
andyleejordan
force-pushed
the
andschwa/fix-f5-operator
branch
from
b719512 to
d827121
Compare
|
@SeeminglyScience Ok there we go! |
SeeminglyScience
approved these changes
Jan 1, 2022
src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also corrects the scope of the script's parameter variables to be
Localinstead ofCommandin theDebuggerAcceptsScriptArgstest, andLocalinstead ofAutofor most of the rest of the tests (as theywere previous to the pipeline work). Excitingly, this even fixes the
DebuggerSetsVariablesNoConversiontest, althoughDebuggerSetsVariablesWithConversionis still broken (for a different reason).Fixes PowerShell/vscode-powershell#3715.