Fix running untitled scripts with arguments (but break line breakpoints)

[andyleejordan]

So the extant hack that enabled debugging untitled scripts is really
untenable. It shifted the user's args by one since it ran the untitled
script as the first arg to the dot-source operator. Unfortunately, there
doesn't seem to be a clear way to break on lines in an untitled script.
However, Wait-Debugger and command breakpoints should still work.

Fixes PowerShell/vscode-powershell#3655
Fixes PowerShell/vscode-powershell#3770

[andyleejordan]

This essentially reverts #1611 and stops attempting to quote arguments given to the script launcher.

[JustinGrote]

LGTM. RIP argumentescapingtests 🪦

[TylerLeonhardt]

darn :( I really liked untitled script debugging

[andyleejordan]

You can still debug it, just not with line breakpoints. We cannot support both that and passing arguments to the script. Wait-Debugger in your script works, as does command breakpoints.

[ALIENQuake]

@andschwa
This seems like an outstanding feature for day-to-day development and I don't agree that it should be removed over 'passing parameters'. Passing parameters are meant for actual files. You can also wrap script content as a function and pass parameters. You can also provide default values for parameter variables at the beginning of the file. But since this is a lost cause already, can you please add an option to restore old behavior?

Also, I reverted to the previous version of the Preview extension and I'm not able to perform 'untitled script debugging'. This is the code I'm using:

Get-ChildItem 'C:\'
$a = Get-Verb | select -First 3 # <- the line breakpoint
Get-item '.'

What I'm missing? What is the latest extension version that has this feature enabled?

[andyleejordan]

@ALIENQuake We are indeed looking to see if we can keep both behaviors. We don't want to keep the hack that previously supported the feature, but are trying to find a way to do it in a less hacky manner. Thing is, in my experience the line breakpoints were frequently off by one in untitled files because it was not a file being passed but the parsed AST.

[andyleejordan]

The fix for this is out in PowerShell Preview! Line breakpoints were re-enabled and arguments are supported! Please note that the code that's run looks funky ('cause it is) but it works!

[ALIENQuake]

@andschwa Wonderfull! Many thanks for your extra effort 👍🏻

EDIT: It works only on PowerShell 6+, it's by design? Not that it's any problem for me, just asking.

[andyleejordan]

To be totally clear I would say in PowerShell 7+ by design (where the APIs to do this are available). PowerShell 6 isn't supported by us or even by itself any more 😉