Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for accidentally allowing removal of $psEditor #1828

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

andyleejordan
Copy link
Member

This adds a regression test for PowerShell/vscode-powershell#3718.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Jun 14, 2022
@andyleejordan andyleejordan requested a review from a team June 14, 2022 00:12
@andyleejordan
Copy link
Member Author

@SeeminglyScience Do you see a better way to write this test?

@andyleejordan andyleejordan force-pushed the andschwa/pseditor-test branch from 0493ec3 to e1c1550 Compare June 14, 2022 19:05
@andyleejordan andyleejordan enabled auto-merge (squash) June 14, 2022 19:24
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@andyleejordan andyleejordan merged commit 5f08df6 into master Jun 14, 2022
@andyleejordan andyleejordan deleted the andschwa/pseditor-test branch June 14, 2022 21:45
@andyleejordan andyleejordan mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants