Fix release build #1933
Merged
Fix release build #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/fix-release-build
branch
5 times, most recently
from
c8864d3 to
5236e73
Compare
I expect this to fail because unfortunately the bug is that our tests are invoked after the build, and not in release configuration, which means they build in debug configuration and overwrite the prior built bits, screwing everything up!
andyleejordan
force-pushed
the
andschwa/fix-release-build
branch
from
5236e73 to
1b7dd3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertion to build that bits are built in release configuration and invoke tests in release configuration. Resolves PowerShell/vscode-powershell#4218 by (correctly and how it was expected in the first place) preventing the developer option to wait for debugger to be in the binary.