-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Breakpoint Label frame to optimize debug stepping performance #2190
base: main
Are you sure you want to change the base?
Conversation
@SeeminglyScience @andyleejordan I made this a fairly minimal PR to be easy to review. Additional things I plan to do next as future incrementals
|
I'm super excited for all of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SeeminglyScience and I are going to take a closer look at this just to be sure nothing got missed.
src/PowerShellEditorServices/Services/DebugAdapter/Handlers/StackTraceHandler.cs
Outdated
Show resolved
Hide resolved
…ackTraceHandler.cs Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
PR Summary
Implements DAP
DelayedStackTraceLoading
and returns an artificial breakpoint label frame based on the invocation info ASAP once the debugger stops. The rest of the stack trace is then returned on a future request that doesn't block the client UI.Capture.mp4
PR Context
Debug stepping takes 300ms+ due to waiting for stack trace collection via the slow
Get-PSCallStack
"hack". Further improvements will come around this later.