Final fixes before 0.1.0 release #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the language server protocol to respond to some last minute changes in VS Code's JSON RPC messages.
This change introduces a "fix" for the issue where the language service host process will spin at high CPU if the client's input stream terminates unexpectedly. This issue is caused by incorrectly handling the result of Stream.ReadAsync which states that a result of 0 means that the stream has terminated. Instead of returning true and continuing the read loop, I now throw an EndOfStreamException which causes the app to terminate with an unhandled exception. A future fix will be implemented to provide a more graceful shutdown path.
This change renames the PowerShellSession class to PowerShellContext to avoid confusion with the existing concept of a PSSession in PowerShell.
This change catches the GetValueInvocationException that can be raised in VariableDetails.GetChildren() when it is called on a thread other than the debugger pipeline thread. In the future, all requests for children of a variable should be done on this thread. For now we just catch the exception so that the debug adapter does not crash.
|
Hi @daviwil, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
daviwil
added a commit
that referenced
this pull request
Nov 17, 2015
Final fixes before 0.1.0 release
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Update PowerShell.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes final protocol changes and bug fixes before the 0.1.0 release.