Fix finding variable definitions in workspace #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
approved these changes
May 19, 2017
| @@ -14,25 +14,31 @@ namespace Microsoft.PowerShell.EditorServices | |||
| internal class FindDeclartionVisitor : AstVisitor | |||
There was a problem hiding this comment.
Mind fixing the typo in the name of this class? FindDeclarationVisitor. That's bugged me for a while :)
|
To take
The advantage with 2 is that we will have a robust solution and the techniques used there can then also be used in rename logic. |
|
I'm all for using the existing variable analysis logic, maybe it's better to wait to do that until we can centralize our analysis and workspace logic in a reusable module |
|
The existing variable analysis logic is still somewhat buggy and needs some work. But I agree that we should centralize our analysis logic then use it from there. |
|
Thanks dude! Feel free to merge it once the tests pass |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
First phase of streamlined development setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PowerShell/vscode-powershell#710