Skip to content

Attempt to fix issue with stepping in dbgr on Linux #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rkeithhill
Copy link
Contributor

Fix #554

I'm not entirely sure about this fix but what I observed is that you could step once in the debugger on Linux but the second step did nothing until you pressed a key in the interactive session. That would wake up this code on the blocking ReadKey() and every time the token was set to cancel. The thought was to not block on ReadKey() but wake up every 100 mSecs and check if a key is available and also if cancellation was requested. What I don't know is if this would slow down fast typing. At 100 mSecs I wouldn't think so.

@rkeithhill rkeithhill requested a review from daviwil October 22, 2017 07:55
@daviwil
Copy link
Contributor

daviwil commented Oct 23, 2017

Hmmm, I really hope ReadKey isn't the problem here. I used to use KeyAvailable but on Linux and macOS it causes all keys typed to be echoed to the terminal. Try using Get-Credential in the terminal and see if your password gets echoed back to you. I don't know that we'll be able to use this as the solution, I might need to investigate further.

@rkeithhill
Copy link
Contributor Author

I'll try that tonight. BTW if there is another fix that is better, I'm all for it. We should probably look into what else is being blocked by the lock this code is residing in. Although blocking code in a lock, isn't that frowned up except maybe in producer/consumer scenarios?

@rkeithhill
Copy link
Contributor Author

rkeithhill commented Oct 24, 2017 via email

@rkeithhill
Copy link
Contributor Author

This approach echos the password to the screen when executing Get-Credential and the backspace key doesn't work. Crud.

@rkeithhill rkeithhill closed this Oct 24, 2017
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this pull request Feb 26, 2019
Running scripts in the integrated console should not steal focus
@rkeithhill rkeithhill deleted the rkeithhill/is554-dbg-stepping-on-linux branch April 1, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux/Ubuntu - Issue Triage
2 participants