In PSCore RemoteSessionStateProxy.InvokeCommand throws PSNotImpemente… #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dException Fixes PowerShell#1091 - I think. Well, at least the initial layer of the onion. Not sure what else we'll run into connecting to PS Core as the remote. I don't have a setup for testing that atm. Probably don't want to crash the extension if we can get aliases when the remote is PS Core. See https://github.com/PowerShell/PowerShell/blob/4bc52d2358222084738157a08907fac32d13bd3a/src/System.Management.Automation/engine/remoting/client/remoterunspace.cs#L2982-L2988
|
Ouch. Thanks for the fix! |
|
Actually, maybe you should also set areAliasesLoaded to true to prevent it from trying to fetch them again? |
|
I'm still a bit confused though. When I open SMA.dll v3 in dotPeek, I see that RemoteSessionStateProxy.InvokeCommand throws the same exception. I wonder if we should not be calling this proxy? |
Do this when we receive a PSNotSupportedException trying to get aliases from the (remote) session.
|
Hmm, the builds are vexing me. This last change shouldn't impact breakpoint tests. |
rkeithhill
deleted the
rkeithhill/is1091-psedit-remote-pscore-crashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dException
Fix #1091 - I think. Well, at least the initial layer of the onion. Not sure what else we'll run into connecting to PS Core as the remote. I don't have a setup for testing that atm.
Probably don't want to crash the extension if we can't get aliases when the remote is PS Core.
See https://github.com/PowerShell/PowerShell/blob/4bc52d2358222084738157a08907fac32d13bd3a/src/System.Management.Automation/engine/remoting/client/remoterunspace.cs#L2982-L2988