Skip to content

Conversation

@rkeithhill
Copy link
Contributor

I'm not entirely sure this is supported:

src/PowerShellEditorServices/Session/*ReadLine*.cs 

guess we just have to see once this is merged.

@rkeithhill
Copy link
Contributor Author

Hmm, this PR should have no impact on the build whatsoever.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this idea! You could put @rjmholt as global as well... If he wants it 😉

@TylerLeonhardt
Copy link
Member

Travis was failing to download PowerShell... Passing now :)

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to be a global reviewer too.

LGTM!

@rkeithhill rkeithhill merged commit cfea694 into master Jun 8, 2018
@rkeithhill rkeithhill deleted the rkeithhill/codeowners branch June 8, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants