{WIP} (GH-812) Update folder for DSC style scripts #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @SeeminglyScience This asserts that DSC scripts are ok with the folder. |
glennsarti
force-pushed
the
gh-812-folding-for-dsc
branch
2 times, most recently
from
c7f439d to
d937945
Compare
The AST contains the most correct version of how a script is interpreted. This includes regions of text. Currently the code folder only uses the Tokens which requires the folder to re-implement some of the AST behaviour e.g. matching token pairs for arrays etc. The code folder should be implemented using as much of the AST as possible. This commit; * Moves most of the region detection to use the AST Extents and uses a new FindFoldsASTVisitor. * Modifies the tests and language server to use the new method fold detection class. * Moved the code to modify the end line of folding regions to the language server code.
glennsarti
force-pushed
the
gh-812-folding-for-dsc
branch
from
d937945 to
ebe7164
Compare
Previously the code folding was not tested against DSC configuration scripts. This commit; * Adds tests for a sample DSC script to ensure the folding occurs at the correct places * Adds an AST visitor for the ParamBlockAST object. This typically spans multiple lines. This commit also adds tests for this scenario
glennsarti
force-pushed
the
gh-812-folding-for-dsc
branch
from
ebe7164 to
3846132
Compare
|
Closed in preference to #853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code folding was not tested against DSC configuration scripts.
This commit;
places
multiple lines. This commit also adds tests for this scenario
Builds on PR #806
Fixes #812