Ensure NamedPipeServerStream is assigned in Windows PowerShell #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
TylerLeonhardt,
SeeminglyScience and
rkeithhill
and removed request for
TylerLeonhardt
rjmholt
changed the title
TylerLeonhardt
approved these changes
May 14, 2019
| @@ -13,7 +13,9 @@ | |||
| using System.Runtime.InteropServices; | |||
| using System.Security.AccessControl; | |||
| using System.Security.Principal; | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | ||
| using System.Diagnostics; |
|
I can't believe I forgot to make that assignment 🤦♂️ |
rjmholt
changed the title
| @@ -20,28 +20,29 @@ namespace Microsoft.PowerShell.EditorServices.Protocol.MessageProtocol.Channel | |||
| public class NamedPipeServerListener : ServerListenerBase<NamedPipeServerChannel> | |||
| { | |||
| // This int will be casted to a PipeOptions enum that only exists in .NET Core 2.1 and up which is why it's not available to us in .NET Standard. | |||
| private const int CurrentUserOnly = 536870912; | |||
| private const int CurrentUserOnly = 0x20000000; | |||
There was a problem hiding this comment.
Lol that explains the weird decimal number
rkeithhill
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #954.
There was a small missing assignment in the startup under the .NET Framework branch.
WIP because I'm going to make some style changes :)Merging this will also make #944 pass its Windows PS test!