Refactor build logic to avoid saving modules in subfolders #979
Conversation
|
|
|
Not sure why the macOS CI failed, but I don't think it was my change. |
|
Should I remove/change the calls to Write-Host while I'm at it? They were already there but Codacy doesn't like it. |
|
No need. They are valid for this usecase. Just ignore Codacy |
Does Codacy have a way to tell it to ignore things like PSSA does? Would it be worth (not necessarily in this PR) adding comments or directives indicating that we're aware of the rule "violation" and provide justification? |
|
@corbob I think so? @adityapatwardhan do you know how we could configure Codacy with the Rules we care about? |
|
So basically we need to contribute to https://github.com/adityapatwardhan/ps-codacy to allow for settings file support, then @adityapatwardhan can publish a new version and codacy will automagically pick it up. |
PowerShellEditorServices.build.ps1
Outdated
|
|
||
| Get-ChildItem -Path $moduleSubfolder -Recurse -Force | Move-Item -Destination $moduleInstallPath -Force | ||
|
|
||
| if ($null -eq (Get-ChildItem -Path $moduleSubfolder -Recurse -Force)) |
There was a problem hiding this comment.
I'd turn this into if ($null -ne (...)) { throw $message } and then proceed with the golden path operation
There was a problem hiding this comment.
Good call. I've changed it.
Fixes PowerShell/vscode-powershell#2027
This PR refactors part of the build logic in
PowerShellEditorServices.build.ps1, to avoid saving the modules defined in modules.json in versioned subfolders. This allows the modules (currently Plaster and PSScriptAnalyzer) to be loaded when running on PowerShell 3 and 4.It also moves the modules out of a subfolder in case they're already present and saved from a previous build (wasn't sure if I could assume a clean build).
The build script itself also works in PowerShell 3 and up.
Build and extension both tested on Windows PowerShell 3 and 5.1 & PowerShell 7-preview.