Move PowerShellEditorServices over to Omnisharp-lsp #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bolshandler add dummy workspace symbols handler
…esymbolshandler A working WorkspaceSymbolsHandler
* Added Diagnostics * didChangeConfiguration message and general settings support * Apply suggestions from code review Co-Authored-By: Robert Holt <rjmholt@gmail.com>
* Added Diagnostics * didChangeConfiguration message and general settings support * initial folding support * log level trace * folding works with latest omnisharp version * comment typo * added test for folding
|
On second thought, I think I'm going to merge this into an omnisharp-lsp branch and work out of that. Let me know if anything jumps out at you in this implementation but do keep in mind it's WIP state. |
rjmholt
approved these changes
Jul 29, 2019
|
So far I've found a big issue with our current formatting implementation - for some reason, our formatter is registered in |
|
The reason OnType Formatting is sooooo bad is because of this code which performs multiple round trips from PSES to vscode-powershell with EVERY OnType request... |
|
Also, my goal is to use the PowerShellContext as little as possible... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, this will delete:
PowerShellEditorServices
PowerShellEditorServices.Host
PowerShellEditorServices.Protocol
And move to a single
PowerShellEditorServices.Engineproject that leverages the Omnisharp csharp-language-server-protocol package that abstracts away all the message handling of the language server protocol and debug adapter protocol.Not all messages are handled yet, as this is a huge refactor... but progress on this can be seen here on my Notion board.
I'm trying to fill out the Pester tests as a go along as a form of smoke tests. If anyone has any interest in helping with this effort please let me know and we can coordinate.
I'm very pleased with this project (the csharp-language-server-protocol) - we can write "Services" and "Handlers" in their own files that we can more easily write tests for (tests would be an awesome way to help me in getting this in).
It's still going to take time, but I'm looking forward to getting this in.