Publish module to ACR #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+222
to
+234
| - pwsh: | | ||
| $modulePath = Join-Path $(drop) -ChildPath 'Microsoft.PowerShell.SecretManagement.$(version).nupkg' | ||
| $fileExists = Test-Path $modulePath | ||
| Write-Verbose -Verbose "Module file $modulePath Exists: $fileExists" | ||
|
|
||
| $srcDir = Join-Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot' -ChildPath 'SrcFiles' | ||
| New-Item $srcDir -ItemType Directory | ||
|
|
||
| $dest = Join-Path $srcDir -ChildPath 'Microsoft.PowerShell.SecretManagement.$(version).nupkg' | ||
| Copy-Item -Path $modulePath -Destination $dest | ||
|
|
||
| Get-ChildItem '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/SrcFiles/' | ||
| displayName: Move artifact to Ev2 folder |
There was a problem hiding this comment.
Suggested change
| - pwsh: | | |
| $modulePath = Join-Path $(drop) -ChildPath 'Microsoft.PowerShell.SecretManagement.$(version).nupkg' | |
| $fileExists = Test-Path $modulePath | |
| Write-Verbose -Verbose "Module file $modulePath Exists: $fileExists" | |
| $srcDir = Join-Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot' -ChildPath 'SrcFiles' | |
| New-Item $srcDir -ItemType Directory | |
| $dest = Join-Path $srcDir -ChildPath 'Microsoft.PowerShell.SecretManagement.$(version).nupkg' | |
| Copy-Item -Path $modulePath -Destination $dest | |
| Get-ChildItem '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/SrcFiles/' | |
| displayName: Move artifact to Ev2 folder | |
| - task: CopyFiles@2 | |
| SourceFolder: $(drop) | |
| Contents: Microsoft.PowerShell.SecretManagement.$(version).nupkg | |
| TargetFolder: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/SrcFiles/ |
Comment on lines
+235
to
+241
| - pwsh: | | ||
| $srcPath = Join-Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot' -ChildPath 'Shell' | ||
| $pathToRunTarFile = Join-Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/Shell' -ChildPath "Run.tar" | ||
| tar -cvf $pathToRunTarFile -C $srcPath ./Run | ||
| $tarExists = Test-Path $pathToRunTarFile | ||
| Write-Verbose -Verbose "Tar file $pathToRunTarFile exists: $tarExists" | ||
| displayName: Compress Run script into tar file as needed for EV2 Shell extension |
There was a problem hiding this comment.
Suggested change
| - pwsh: | | |
| $srcPath = Join-Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot' -ChildPath 'Shell' | |
| $pathToRunTarFile = Join-Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/Shell' -ChildPath "Run.tar" | |
| tar -cvf $pathToRunTarFile -C $srcPath ./Run | |
| $tarExists = Test-Path $pathToRunTarFile | |
| Write-Verbose -Verbose "Tar file $pathToRunTarFile exists: $tarExists" | |
| displayName: Compress Run script into tar file as needed for EV2 Shell extension | |
| - task: ArchiveFiles@2 | |
| inputs: | |
| rootFolderOrFile: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/Shell/Run | |
| includeRootFolder: false | |
| archiveType: tar | |
| tarCompression: None | |
| archiveFile: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/Shell/Run.tar | |
| displayName: Compress Run script into tar file as needed for EV2 Shell extension |
| [xml]$xml = Get-Content Directory.Build.props | ||
| $version = $xml.Project.PropertyGroup.ModuleVersion | ||
|
|
||
| for ($i=0; $i -lt $envVarArrayLen; $i++) |
There was a problem hiding this comment.
Per Viv's idea: we remove the predefined values from the environmentValues array and simply build its contents here, instead of having to iterate over it with a bunch of checks and sets.
Comment on lines
+329
to
+338
| - task: DownloadPipelineArtifact@2 | ||
| inputs: | ||
| targetPath: '$(Pipeline.Workspace)' | ||
| artifact: drop_PrepForEV2_CopyEv2FilesToArtifact | ||
| displayName: 'Download drop_PrepForEV2_CopyEv2FilesToArtifact artifact that has all files needed' | ||
| - task: DownloadPipelineArtifact@2 | ||
| inputs: | ||
| buildType: 'current' | ||
| targetPath: '$(Pipeline.Workspace)' | ||
| displayName: 'Download to get EV2 Files' |
There was a problem hiding this comment.
Suggested change
| - task: DownloadPipelineArtifact@2 | |
| inputs: | |
| targetPath: '$(Pipeline.Workspace)' | |
| artifact: drop_PrepForEV2_CopyEv2FilesToArtifact | |
| displayName: 'Download drop_PrepForEV2_CopyEv2FilesToArtifact artifact that has all files needed' | |
| - task: DownloadPipelineArtifact@2 | |
| inputs: | |
| buildType: 'current' | |
| targetPath: '$(Pipeline.Workspace)' | |
| displayName: 'Download to get EV2 Files' | |
| - download: current | |
| displayName: Download artifacts |
| $secretManagementFileName = "Microsoft.PowerShell.SecretManagement.$($env:SECRET_MANAGEMENT_VERSION).nupkg" | ||
|
|
||
| Write-Verbose -Verbose "Download files" | ||
| Invoke-WebRequest -Uri $env:SECRET_MANAGEMENT_MODULE -OutFile $secretManagementFileName |
There was a problem hiding this comment.
We're both just curious what the original value of SECRET_MANAGEMENT_MODULE is, and why we have to "download" it in the container. Like, is it a local URI?
| @@ -0,0 +1 @@ | |||
| 1.0.1 | |||
There was a problem hiding this comment.
Will we need to update this? When? Is it tied to the package version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish module to ACR as an intermediate step to publish module to MAR.
PR Summary
PR Context
Add step to run Ev2 shell extension that publishes module to our ACR.