Skip to content

Open in ISE keyboard shortcut overwrites basic editing keyboard shortcut #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AikenBM opened this issue Dec 4, 2017 · 5 comments
Closed

Comments

@AikenBM
Copy link

AikenBM commented Dec 4, 2017

In package.json, you're overriding Shift+Alt+i, which is the default VS Code keyboard shortcut for Insert cursor at end of each line selected (i.e., editor.action.insertCursorAtEndOfEachLineSelected) which is one of the Basic Editing keyboard shortcuts. This is they keyboard shortcut that lets you select a block of text and easily edit each line in that block simultaneously. There is no alternative default shortcut for this feature.

There are dozens of possible keyboard shortcuts for this. Is it possible to not select one of the default bindings designated for basic editing for the application?

@daviwil
Copy link
Contributor

daviwil commented Dec 4, 2017

Do you have a suggestion for an alternative?

@AikenBM
Copy link
Author

AikenBM commented Dec 4, 2017

It doesn't particularly matter. I just think that it shouldn't be a keyboard shortcut that VS Code already uses for editing. Colliding with another extension is fine because they should use editorTextFocus && editorLangId = '<Language>'. Colliding with the basic editing shortcuts is going to confuse people.

Something like Ctrl+Alt+i or Ctrl+Shift+i or Ctrl+Alt+Shift+i would be fine, and closely approximates the current shortcut.

@TylerLeonhardt
Copy link
Member

I've got #1117 out now to change the "Open in ISE" shortcut to Ctrl+Alt+i

@TylerLeonhardt
Copy link
Member

@daviwil let me know that ctrl+Alt+ cannot be used - throws a warning in the dev console and ctrl+shift+i opens the dev console.

I've got shift+alt+p working and I don't think I've overwritten anything - what do you think?

@TylerLeonhardt
Copy link
Member

This will be in 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants