Skip to content

Should not use the "onDebug" activation event #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roblourens opened this issue Jan 29, 2018 · 1 comment · Fixed by #1181
Closed

Should not use the "onDebug" activation event #1179

roblourens opened this issue Jan 29, 2018 · 1 comment · Fixed by #1181
Assignees
Labels

Comments

@roblourens
Copy link

vscode-powershell is using the onDebug activation event, which causes it to be activated any time a debug session of any type is started. (https://github.com/PowerShell/vscode-powershell/blob/master/package.json#L29)

In 1.19 we added the more fine-grained onDebugResolve:type and onDebugInitialConfigurations activation events which let extensions be activated only when they need to be to resolve debug configs. One consequence is that when I start debugging a node app, I get a terminal popup from the powershell extension that says An error occurred while starting PowerShell Editor Services: .... Ideally I'd only see that when I'm doing something powershell-related.

More details here: https://code.visualstudio.com/updates/v1_19#_debug-contributions-in-packagejson

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jan 29, 2018

Thanks for the report, @roblourens! We'll address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants