terminal process exited with code:1

[ajpaul18]

Issue Type: Bug

During VS Code startup,Powershell Terminal exits with the following errors

1. Terminal process exited with code :1
2. The language service could not be started

Extension version: 1.7.0
VS Code version: Code - Insiders 1.23.0-insider (a656d397e424173c86f32703e0c0293bd8084da0, 2018-05-03T00:07:45.778Z)
OS version: Windows_NT ia32 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU W3565 @ 3.20GHz (8 x 3192)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	11.99GB (5.32GB free)
Process Argv	C:\Program Files (x86)\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader	no
VM	40%

[TylerLeonhardt]

Thanks for this. I noticed your VSCode version is quite behind... Can you upgrade to the latest and try again?

[rjmholt]

Hi @ajpaul18, thanks for opening an issue. This looks like a startup crash in EditorServices, but we'll need to collect more information to work out what the root problem is.

Out of curiosity, does red text flash in the console before the crash occurs? If so, the best way to work out what it says is a screen recorder (like a screen to GIF recorder). (Making that diagnosis easier is on the list of things to improve!)

[rjmholt]

Oh, yeah, like @tylerl0706 says, also worth upgrading VSCode!

[ajpaul18]

I have updated to july 2018. Still the console crashes.
@rjmholt There is no red text flashing in the console before the crash, the console crashes immediately in startup.

[rkeithhill]

I believe the issue is that your home dir is named Night's Watch. That single quote inside a single quoted path to the script is causing a parse error. BTW this impacts not only the script path but also the BundledModulesPath, LogPath and SessionDetailsPath.

We would either need to double-up single quotes or switch to using double quotes. Using double quotes is problematic because of unintentional interpolation. Perhaps we preprocess these four paths to "escape" (double) the single quotes.

[rjmholt]

@ajpaul18 No need for red text, that message is the important bit.

We should probably do some string escaping for the start script call

[ajpaul18]

Yes,the user name is the problem. i tried installing in another user account , it worked fine.

[rkeithhill]

We should be able to fix this though.

[ajpaul18]

Update the regex in the start script?

[rkeithhill]

It fails before it even starts the start script. This needs to be fixed in the extension where we launch powershell.exe with those args. I'm working on a fix right now but I don't have a good test case for this. Perhaps you could test it for me? Nevermind, figured out an easy way to test it (without renaming my home dir or creating a new user).

[rkeithhill]

OK, have a fix. If you would like to try it out. Download this zip and extract the two files into your ~\.vscode\extensions\ms-vscode.powershell-1.7.0\out\src\features dir. I would back up the two existing files first (process.js and session.js), so you can revert if needed.

updated-js-files.zip

I you try this, please let us know if it fixes the issue for you.

[ajpaul18]

@rkeithhill & @tylerl0706 .. Thanks guys, the fix works.
That issue was so annoying. Glad you guys could help me. Cheers mates

[rkeithhill]

Let's let the PR merge automatically close this issue. :-)