Integrated terminal crashes with PS Extension V2 when stopping interactive debug session

[muzzar78]

Issue Description

I am experiencing a problem with PowerShell integrated terminal crashing when I stop an interactive debugging session. I'm able to replicate the problem each time I stop the interactive debugging session.

Attached Logs

vscode-powershell.zip

Follow the instructions in the README about
capturing and sending logs.

Environment Information

Visual Studio Code

Name	Version
Operating System	Windows_NT x64 10.0.17134
VSCode	1.27.2
PowerShell Extension Version	2.0.0

PowerShell Information

Name	Value
PSVersion	6.1.0
PSEdition	Core
GitCommitId	6.1.0
OS	Microsoft Windows 10.0.17134
Platform	Win32NT
PSCompatibleVersions	1.0 2.0 3.0 4.0 5.0 5.1.10032.0 6.1.0
PSRemotingProtocolVersion	2.3
SerializationVersion	1.1.0.1
WSManStackVersion	3.0

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)

Extension	Author	Version
azure-account	ms-vscode	0.4.3
azurerm-vscode-tools	msazurermtools	0.4.2
csharp	ms-vscode	1.16.1
gitlens	eamodio	8.5.6
kubernetes-snippets	ipedrazas	0.1.9
markdown-pdf	yzane	1.2.0
PowerShell	ms-vscode	2.0.0
vscode-azurestorage	ms-azuretools	0.4.1
vscode-docker	PeterJausovec	0.2.0
vscode-kubernetes-tools	ms-kubernetes-tools	0.1.13
vscode-yaml	redhat	0.0.16

[muzzar78]

I did some more testing. This issue occurs when in the interactive session I launch a script with a breakpoint. Then if I stop the debugger while inside the script the error occurs. If I step through the script to completion then stop the debugger the issues doesn't occur.

[TylerLeonhardt]

Thanks for the update @muzzar78 can you repro this crash in 1.9.0? I'd like to determine that the issue is in v2.

[rjmholt]

I think this is also in 1.9.0 -- see #1494. I think this is probably a duplicate of that issue -- although the more data we have the better.

[muzzar78]

I have tested with 1.9.0 and can't reproduce the issue. I was thinking it might have something to do with the script context. In 2.0.0 I can see the following error

2018-10-06 01:18:52.283 [ERROR] C:\Users\roholt\Documents\Dev\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\Server\DebugAdapter.cs: In method 'OnExecutionCompleted', line 121:
Exception occurred while awaiting debug launch task.

System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.PowerShell.EditorServices.Protocol.Server.DebugAdapter.d__22.MoveNext()

and then

2018-10-06 01:18:52.297 [ERROR] C:\Users\roholt\Documents\Dev\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs: In method 'OnListenTaskCompleted', line 391:
ProtocolEndpoint message loop terminated due to unhandled exception:

System.AggregateException: One or more errors occurred. ---> System.ObjectDisposedException: Cannot access a closed pipe.

[rjmholt]

Duping this to #1494 so we can keep all the discussion there.