Skip to content

No indication that PowerShell code is running #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcgeek86 opened this issue Apr 21, 2016 · 10 comments
Closed

No indication that PowerShell code is running #154

pcgeek86 opened this issue Apr 21, 2016 · 10 comments
Labels
Area-Extension Terminal Hackathon Up for grabs, especially at Hackathons! Issue-Enhancement A feature request (enhancement).

Comments

@pcgeek86
Copy link
Contributor

VSCode Version: 1.0.1-insiders
OS: Windows 10 RTM 1511

  • Ran some PowerShell code (F8)
  • Closed the Output window
  • Ran more PowerShell code (F8)
  • Had no indication it was running / VSCode GUI was static
  • Finally thought to open Output window and check
  • Changed Output window from "Tasks" to "PowerShell Output"
  • Found output

Is there an opportunity here to improve the user experience? Perhaps not a priority, but it would be nice to know that "something is happening" when you use the "PowerShell: Run Selection" command in VSCode.

Cheers,
Trevor Sullivan
https://trevorsullivan.net
https://twitter.com/pcgeek86

@daviwil
Copy link
Contributor

daviwil commented Apr 25, 2016

That's a great point. Maybe we can change the status bar text while the script is running to indicate that something is happening?

@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Apr 25, 2016
@daviwil daviwil added this to the Backlog milestone Apr 25, 2016
@pcgeek86
Copy link
Contributor Author

@daviwil yep, something like that would be cool.

@sevenam
Copy link

sevenam commented Aug 26, 2016

+1 for this. I really, really miss this functionality!

I think this is the only thing missing to make Powershell ISE obsolete for my part.

As far as I can see, there is no real indication that code is running, even with the Powershell Output window up (other than any output that is to be written to shell is missing).

@daviwil
Copy link
Contributor

daviwil commented Aug 26, 2016

Good point! I'll do something about this soon.

@daviwil daviwil modified the milestones: 0.8.0, Backlog Aug 26, 2016
@daviwil daviwil modified the milestones: 0.9.0, 0.8.0 Dec 14, 2016
@daviwil daviwil modified the milestones: 0.11.0, 0.10.0 Mar 14, 2017
@daviwil daviwil modified the milestones: 0.11.0, 0.12.0, Next Patch Update Mar 22, 2017
@daviwil daviwil modified the milestones: Next Patch Update, Next Feature Update Apr 6, 2017
@daviwil daviwil modified the milestones: April 2017, May 2017 May 8, 2017
@daviwil daviwil modified the milestones: May 2017, June 2017 Jun 1, 2017
@daviwil daviwil modified the milestones: June 2017, May 2017 Jun 1, 2017
@daviwil daviwil modified the milestones: June 2017, July 2017 Jul 11, 2017
@daviwil daviwil modified the milestones: July 2017, Future Oct 26, 2017
@pcgeek86
Copy link
Contributor Author

@tylerl0706 This minor enhancement could be an easy win for the VSCode-PowerShell development experience.

@TylerLeonhardt
Copy link
Member

Thanks for that @pcgeek86! This looks relatively trivial.

@TylerLeonhardt TylerLeonhardt added the Hackathon Up for grabs, especially at Hackathons! label Feb 21, 2018
@SeeminglyScience
Copy link
Collaborator

The easiest way to do this would probably be to create ExecutionStartedEvent and ExecutionEndedEvent notifications for PowerShellEditorServices to send to the editor. One way to send the events would be to have the LanguageService attach to the ExecutionStatusChanged event on PowerShellContext.

@rjmholt
Copy link
Contributor

rjmholt commented Mar 12, 2018

I have a working implementation for this (just a text-in-status-bar update): client and server.

I'll add some tests and open PRs for each component.

I'm fairly new to the PowerShell extension client/server codebase and to VS Code's API, so looking for any feedback on my implementation (particularly suspect is this bit).

EDIT - a preview:
Execution status update in PowerShell extension

@TylerLeonhardt
Copy link
Member

Fixed in #1227 🎉

Now you'll see a little spinner as well as some text 😄

all thanks to @rjmholt 🎉

@pcgeek86
Copy link
Contributor Author

@tylerl0706 Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Hackathon Up for grabs, especially at Hackathons! Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

6 participants