Process terminated bue to StackOverFlow - process terminated with code 3221225725

[Amir-Mir]

Issue Type: Bug

The PowerShell process keep getting terminated. The keeps getting terminated and this goes on in loop.

Extension version: 1.9.0
VS Code version: Code 1.29.0 (5f24c93878bd4bc645a4a17c620e2487b11005f9, 2018-11-12T07:47:15.448Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.69GB (14.92GB free)
Process Argv
Screen Reader	no
VM	0%

[rjmholt]

Hi @BadSqlPro, thanks for opening an issue.

Can you please follow through our troubleshooting docs to attach your PowerShell extension logs.

We will need more information about what happened and a way to reproduce the issue in order to fix it.

[Amir-Mir]

Hello @rjmholt , I followed the instructions and turned on the Verbose logging for "powershell.developer.editorServicesLogLevel": "Verbose". I am attaching the logs here, Please let me know if the logs have the relevant info. I also some screenshots.
Pleas let me know if I can provide further info.

EditorServices.log
Start-EditorServices-EditorServices.log
vscode-powershell.log

[rjmholt]

Thanks for that @BadSqlPro!

So it looks like RecursivelyEnumerateFiles has a problem here. There's a big list of errors like this one:

2018-11-14 12:32:13.221 [ERROR] C:\PowerShellEditorServices\src\PowerShellEditorServices\Workspace\Workspace.cs: In method 'RecursivelyEnumerateFiles', line 270: Could not enumerate files in the path 'c:\$Recycle.Bin\S-1-5-18' due to the path not being accessible
    System.UnauthorizedAccessException: Access to the path 'c:\$Recycle.Bin\S-1-5-18' is denied.
       at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
       at System.IO.FileSystemEnumerableIterator`1.CommonInit()
       at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
       at System.IO.Directory.GetDirectories(String path)
       at Microsoft.PowerShell.EditorServices.Workspace.RecursivelyEnumerateFiles(String folderPath)

(That's the first, but it's identical to the others)

However it looks like that didn't crash anything (but we should handle/log it better).

EditorServices.log's last entry is this:

2018-11-14 12:33:06.025 [VERBOSE] C:\PowerShellEditorServices\src\PowerShellEditorServices\Workspace\Workspace.cs: In method 'GetFile', line 98:
    Opened file on disk: c:\Windows\SysWOW64\WindowsPowerShell\v1.0\Modules\WindowsUpdate\WindowsUpdate.psd1

So there's not much indication of what caused the crash there.

@BadSqlPro how did you determine that the cause of the crash was a stack overflow. If you've got a stack trace or any other error messages, can you share them? Otherwise, we might need to crank up logging to Diagnostic and come up with some repro steps.

[Amir-Mir]

I get a message everytime saying that its a stackoverflow and the PowerShell terminal stops responding and asks for a restart. And this keeps happening in a loop. I had sent you a screenshot of the error messages that I see.

…

On Wed, Nov 14, 2018 at 1:43 PM Robert Holt ***@***.***> wrote: Thanks for that @BadSqlPro <https://github.com/BadSqlPro>! So it looks like RecursivelyEnumerateFiles has a problem here. There's a big list of errors like this one: 2018-11-14 12:32:13.221 [ERROR] C:\PowerShellEditorServices\src\PowerShellEditorServices\Workspace\Workspace.cs: In method 'RecursivelyEnumerateFiles', line 270: Could not enumerate files in the path 'c:\$Recycle.Bin\S-1-5-18' due to the path not being accessible System.UnauthorizedAccessException: Access to the path 'c:\$Recycle.Bin\S-1-5-18' is denied. at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) at System.IO.FileSystemEnumerableIterator`1.CommonInit() at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost) at System.IO.Directory.GetDirectories(String path) at Microsoft.PowerShell.EditorServices.Workspace.RecursivelyEnumerateFiles(String folderPath) (That's the first, but it's identical to the others) However it looks like *that didn't crash anything* (but we should handle/log it better). EditorServices.log's last entry is this: 2018-11-14 12:33:06.025 [VERBOSE] C:\PowerShellEditorServices\src\PowerShellEditorServices\Workspace\Workspace.cs: In method 'GetFile', line 98: Opened file on disk: c:\Windows\SysWOW64\WindowsPowerShell\v1.0\Modules\WindowsUpdate\WindowsUpdate.psd1 So there's not much indication of what caused the crash there. @BadSqlPro <https://github.com/BadSqlPro> how did you determine that the cause of the crash was a stack overflow. If you've got a stack trace or any other error messages, can you share them? Otherwise, we might need to crank up logging to Diagnostic and come up with some repro steps. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1613 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmNqHBIbVplTD48eWpMytlo-dhIoHPt2ks5uvHJqgaJpZM4YeCEA> .

[rjmholt]

Right, I was looking at the screenshot, but it doesn't say stack overflow -- so I was wondering if there's another message?

Anyway, I think we'll need diagnostic logs to work out what's happening here.

[Amir-Mir]

Well, to make matter even worst, my VS Code just wont work at all i.e. with the PowerShell extension. I even uninstalled VS Code and reinstalled it and was hoping that this issue would go away. But when I reinstalled VSCode, I saw all my previous extensions there, looks like they never got uninstalled. If it would help, I have Visual Studio 2015 and 2017 installed on my machine, hope that is not messing up the VS Code. I am also pasting a screenshot of the StackOverFlowException error that I see now, every single time I try to run a piece of PowerShell code. Please let me know how should I proceed.

And then I get these errors on the lower left corner of the window in VS Code.

And when I restart the session by clicking 'Yes' I get this error

[rjmholt]

Visual Studio installations wouldn't (to my knowledge) interfere with anything here either.

Reinstalling VSCode probably wouldn't touch the extensions. For that you need to close and uninstall VSCode, and then delete the ~/.vscode folder (rm -fo -r ~/.vscode will do it on Windows, rm -rf ~/.vscode on other platforms). Then reinstall VSCode.

We still need more information on reproducing the StackOverflowExtension you're seeing. So please set logging to Diagnostic, start the extension and post the logs here once it's crashed.

Another thing to try is finding the ~/.vscode/extensions/ms-vscode.powershell-1.9.0/modules/PowerShellEditorServices/Start-EditorServices.ps1 file, putting a Wait-Debugger in it and stepping through it one line at a time until you hit the crash.

[rjmholt]

My current theory is that there's maybe a cyclic symlink on your system that we try and traverse infinitely and eventually crash on. But I have no idea where we might be doing that.

[Amir-Mir]

I will start the Diagnostic mode but how do I do what you mentioned?. " Another thing to try is finding the ~/.vscode/extensions/ms-vscode.powershell-1.9.0/modules/PowerShellEditorServices/Start-EditorServices.ps1 file, putting a Wait-Debugger in it and stepping through it one line at a time until you hit the crash. "

…

On Fri, Nov 16, 2018 at 11:33 AM Robert Holt ***@***.***> wrote: My current theory is that there's maybe a cyclic symlink on your system that we try and traverse infinitely and eventually crash on. But I have no idea where we might be doing that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1613 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmNqHBoOQGVXA5eiZzaAsbxePinTLylwks5uvvcCgaJpZM4YeCEA> .

[rjmholt]

Try Diagnostic logging first and just attach the logs on GitHub (attaching by email won't work unfortunately).

I don't think the Wait-Debugger option will work actually, since this crash seems to be happening after startup.

So for now, we just need to work out where the crash might be occurring.

[MatthewHamous]

Also running into this issue, see below logs. Identical problems, but I'm not having any issue with the language client not being ready. I've had this occur on my native win10 installation as well as through an RDP connection to a windows server 2012r2 installation.

Win10 info:
Version 10.0.17134 Build 17134
OS Name Microsoft Windows 10 Pro
Processor Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz, 2904 Mhz, 2 Core(s), 4 Logical Processor(s)
System Type x64-based PC
BIOS Version/Date LENOVO N1MET49W (1.34 ), 7/2/2018

VS Code info:
Version: 1.29.0 (user setup)
Commit: 5f24c93878bd4bc645a4a17c620e2487b11005f9
Date: 2018-11-12T07:47:15.448Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

EditorServices.log
vscode-powershell.log

[rjmholt]

Looks like we need some better recursion checking here.

We might have to build a HashSet every time and ignore files that are already in it. Or, if it's a symlink problem, we should just ignore symlinks. Or just set a finite recursion depth of, perhaps, 127 or 255 or something.