-
Notifications
You must be signed in to change notification settings - Fork 513
Process terminated bue to StackOverFlow - process terminated with code 3221225725 #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process terminated bue to StackOverFlow - process terminated with code 3221225725 #1613
Comments
Hi @BadSqlPro, thanks for opening an issue. Can you please follow through our troubleshooting docs to attach your PowerShell extension logs. We will need more information about what happened and a way to reproduce the issue in order to fix it. |
Hello @rjmholt , I followed the instructions and turned on the Verbose logging for "powershell.developer.editorServicesLogLevel": "Verbose". I am attaching the logs here, Please let me know if the logs have the relevant info. I also some screenshots. EditorServices.log |
Thanks for that @BadSqlPro! So it looks like
(That's the first, but it's identical to the others) However it looks like that didn't crash anything (but we should handle/log it better). EditorServices.log's last entry is this:
So there's not much indication of what caused the crash there. @BadSqlPro how did you determine that the cause of the crash was a stack overflow. If you've got a stack trace or any other error messages, can you share them? Otherwise, we might need to crank up logging to Diagnostic and come up with some repro steps. |
I get a message everytime saying that its a stackoverflow and the
PowerShell terminal stops responding and asks for a restart. And this keeps
happening in a loop. I had sent you a screenshot of the error messages that
I see.
…On Wed, Nov 14, 2018 at 1:43 PM Robert Holt ***@***.***> wrote:
Thanks for that @BadSqlPro <https://github.com/BadSqlPro>!
So it looks like RecursivelyEnumerateFiles has a problem here. There's a
big list of errors like this one:
2018-11-14 12:32:13.221 [ERROR] C:\PowerShellEditorServices\src\PowerShellEditorServices\Workspace\Workspace.cs: In method 'RecursivelyEnumerateFiles', line 270: Could not enumerate files in the path 'c:\$Recycle.Bin\S-1-5-18' due to the path not being accessible
System.UnauthorizedAccessException: Access to the path 'c:\$Recycle.Bin\S-1-5-18' is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileSystemEnumerableIterator`1.CommonInit()
at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
at System.IO.Directory.GetDirectories(String path)
at Microsoft.PowerShell.EditorServices.Workspace.RecursivelyEnumerateFiles(String folderPath)
(That's the first, but it's identical to the others)
However it looks like *that didn't crash anything* (but we should
handle/log it better).
EditorServices.log's last entry is this:
2018-11-14 12:33:06.025 [VERBOSE] C:\PowerShellEditorServices\src\PowerShellEditorServices\Workspace\Workspace.cs: In method 'GetFile', line 98:
Opened file on disk: c:\Windows\SysWOW64\WindowsPowerShell\v1.0\Modules\WindowsUpdate\WindowsUpdate.psd1
So there's not much indication of what caused the crash there.
@BadSqlPro <https://github.com/BadSqlPro> how did you determine that the
cause of the crash was a stack overflow. If you've got a stack trace or any
other error messages, can you share them? Otherwise, we might need to crank
up logging to Diagnostic and come up with some repro steps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1613 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmNqHBIbVplTD48eWpMytlo-dhIoHPt2ks5uvHJqgaJpZM4YeCEA>
.
|
Right, I was looking at the screenshot, but it doesn't say stack overflow -- so I was wondering if there's another message? Anyway, I think we'll need diagnostic logs to work out what's happening here. |
Visual Studio installations wouldn't (to my knowledge) interfere with anything here either. Reinstalling VSCode probably wouldn't touch the extensions. For that you need to close and uninstall VSCode, and then delete the We still need more information on reproducing the StackOverflowExtension you're seeing. So please set logging to Another thing to try is finding the |
My current theory is that there's maybe a cyclic symlink on your system that we try and traverse infinitely and eventually crash on. But I have no idea where we might be doing that. |
I will start the Diagnostic mode but how do I do what you mentioned?.
"
Another thing to try is finding the
~/.vscode/extensions/ms-vscode.powershell-1.9.0/modules/PowerShellEditorServices/Start-EditorServices.ps1
file, putting a Wait-Debugger in it and stepping through it one line at a
time until you hit the crash.
"
…On Fri, Nov 16, 2018 at 11:33 AM Robert Holt ***@***.***> wrote:
My current theory is that there's maybe a cyclic symlink on your system
that we try and traverse infinitely and eventually crash on. But I have no
idea where we might be doing that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1613 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmNqHBoOQGVXA5eiZzaAsbxePinTLylwks5uvvcCgaJpZM4YeCEA>
.
|
Try Diagnostic logging first and just attach the logs on GitHub (attaching by email won't work unfortunately). I don't think the So for now, we just need to work out where the crash might be occurring. |
Also running into this issue, see below logs. Identical problems, but I'm not having any issue with the language client not being ready. I've had this occur on my native win10 installation as well as through an RDP connection to a windows server 2012r2 installation. Win10 info: VS Code info: |
Looks like we need some better recursion checking here. We might have to build a HashSet every time and ignore files that are already in it. Or, if it's a symlink problem, we should just ignore symlinks. Or just set a finite recursion depth of, perhaps, 127 or 255 or something. |
Hello Robert, I would like to continue with the investigation into the
issue. Please let me know what you need from me next.
…On Tue, Nov 27, 2018, 6:19 PM Robert Holt ***@***.*** wrote:
Closed #1613 <#1613>
via PowerShell/PowerShellEditorServices#795
<PowerShell/PowerShellEditorServices#795>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1613 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmNqHPlKjSzh5haEHzewvHyscqmYrh7Zks5uzdaigaJpZM4YeCEA>
.
|
The issue was closed automatically since I merged a PR that we think will fix it. We're hoping to release next week, at which point we can follow up to see if the issue is still occurring or not. If it is, we can reopen this issue. |
Got it, sounds good.
…On Wed, Nov 28, 2018 at 11:03 AM Robert Holt ***@***.***> wrote:
The issue was closed automatically since I merged a PR that we think will
fix it. We're hoping to release next week, at which point we can follow up
to see if the issue is still occurring or not. If it is, we can reopen this
issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1613 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmNqHHZjP9OVSO_TVxovdtS5-WhSKAkgks5uzsHCgaJpZM4YeCEA>
.
|
Did the new version already come out with the bug fixes?
…On Wed, Nov 28, 2018 at 11:54 AM Amir Mir ***@***.***> wrote:
Got it, sounds good.
On Wed, Nov 28, 2018 at 11:03 AM Robert Holt ***@***.***>
wrote:
> The issue was closed automatically since I merged a PR that we think will
> fix it. We're hoping to release next week, at which point we can follow up
> to see if the issue is still occurring or not. If it is, we can reopen this
> issue.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1613 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AmNqHHZjP9OVSO_TVxovdtS5-WhSKAkgks5uzsHCgaJpZM4YeCEA>
> .
>
|
Not yet. We're looking to do it on Monday. |
Thank you
…On Thu, Nov 29, 2018 at 11:57 AM Tyler James Leonhardt < ***@***.***> wrote:
Not yet. We're looking to do it on Monday.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1613 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmNqHLdktsH40mUJtn7ybhE5t7MFQ67eks5u0CAmgaJpZM4YeCEA>
.
|
I'm getting the same problem with version 1.43.2. Constantly crashes with error code 3221225725 Problem signature: |
@Firmbyte could you open a new issue for this? This one has been closed for over a year and a half, the extension and underlying LSP has undergone significant changes in that time. |
Issue Type: Bug
The PowerShell process keep getting terminated. The keeps getting terminated and this goes on in loop.
Extension version: 1.9.0
VS Code version: Code 1.29.0 (5f24c93878bd4bc645a4a17c620e2487b11005f9, 2018-11-12T07:47:15.448Z)
OS version: Windows_NT x64 10.0.17134
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: