Skip to content

Expand aliases works silently, needs 'running indicator' #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vors opened this issue Jun 10, 2016 · 8 comments
Closed

Expand aliases works silently, needs 'running indicator' #208

vors opened this issue Jun 10, 2016 · 8 comments
Assignees
Labels
Area-UI Hackathon Up for grabs, especially at Hackathons! Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@vors
Copy link
Contributor

vors commented Jun 10, 2016

When I worked on PowerShell/platyPS#126
I tried use "Expand aliases" on a file with 1.5k lines.

There was no feedback from vscode that it started to do something.
I thought it's not working, but then I checked it in 20 seconds and it was done.
I'm not sure how much time did it take, but since the operation is not instant it requires some visual progress indication for better UX.

It could be applicable to other refactorings as well.

@daviwil
Copy link
Contributor

daviwil commented Jun 10, 2016

Thanks Sergei!

@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Jun 10, 2016
@daviwil daviwil added this to the Backlog milestone Jun 10, 2016
@dfinke
Copy link
Contributor

dfinke commented Jun 10, 2016

Wow, that worked?! :-)

@kapilmb
Copy link

kapilmb commented Jun 13, 2016

With ScriptAnalyzer providing the ability to expand aliases through its SuggestCorrections property, the question I would like to ask is, should we have "expand aliases" have and maintain it's own implementation or use ScriptAnalzyer''s service?

@daviwil
Copy link
Contributor

daviwil commented Jun 13, 2016

Script Analyzer's expansion is nice when the user wants to expand a single alias into the fully-qualified command name. Doug's Expand Alias command does it automatically across the whole file, so I think the intent is a little different. However, if we want to provide this type of "whole-file correction" operation in Script Analyzer we can definitely discuss how to make that happen.

@TylerLeonhardt
Copy link
Member

It would be cool if this could do like:

"50 alias expanded" though a simple "Aliases expanded" would be a good first step.

@TylerLeonhardt TylerLeonhardt added the Hackathon Up for grabs, especially at Hackathons! label Feb 21, 2018
@TylerLeonhardt
Copy link
Member

@rjmholt can you test to see if this is fixed for free with #1227 😄

@TylerLeonhardt TylerLeonhardt added the Up for Grabs Will shepherd PRs. label Mar 20, 2018
@TylerLeonhardt TylerLeonhardt modified the milestone: Future May 24, 2018
@rjmholt rjmholt self-assigned this Oct 10, 2018
@rjmholt
Copy link
Contributor

rjmholt commented Oct 15, 2018

The running indicator I added in #1227 seems to work for this. Closing

@rjmholt rjmholt closed this as completed Oct 15, 2018
@vors
Copy link
Contributor Author

vors commented Oct 16, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Hackathon Up for grabs, especially at Hackathons! Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

6 participants