Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the starting powershell status bar item yellow? #2436

Closed
Tyriar opened this issue Jan 24, 2020 · 3 comments · Fixed by #3531
Closed

Why is the starting powershell status bar item yellow? #2436

Tyriar opened this issue Jan 24, 2020 · 3 comments · Fixed by #3531
Assignees
Labels
Area-UI Issue-Enhancement A feature request (enhancement).

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Jan 24, 2020

Screen Shot 2020-01-24 at 8 27 40 AM

By hardcoding a color in the status bar you're take control away from the theme on guaranteeing contrast. Also the yellow draws the eye when this message can usually be ignored?

Happens to be the same yellow my theme uses for the debug status bar:

image

@ghost ghost added the Needs: Triage Maintainer attention needed! label Jan 24, 2020
@TylerLeonhardt
Copy link
Member

This is a dupe of #1779

That's the primary mechanism for switching the PowerShell version you want to use which is why it has that pop of color.

@TylerLeonhardt TylerLeonhardt added Resolution-Duplicate Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Jan 24, 2020
@Tyriar
Copy link
Contributor Author

Tyriar commented Jan 24, 2020

Well I'm suggesting removing color completely, not being able to customize it or pull it from the theme. The same applies to the orange error one, plain default like tslint (and the notification) would be preferable imo:

Screen Shot 2020-01-24 at 9 31 20 AM

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jan 24, 2020
@ghost
Copy link

ghost commented Jan 25, 2020

This issue has been marked as duplicate and has not had any activity for 1 day. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants