microsoft store installed powershell can not be recognized

[Wongboo]

I used to use powershell delivered by github release, now as I favor the convenience of microsoft-store's integrated update, I switch to powershell in microsoft store.
But then bugs appear:

1. vscode-powershell cannot automatically recognize microsoft store installed powershell
2. even if I changed “PowerShell Additional Exe Paths” in JSON with the value
   $PSHOME\pwsh.exe which is
   "C:\Program Files\WindowsApps\Microsoft.PowerShellPreview_7.2.2.0_x64__8wekyb3d8bbwe\pwsh.exe"
   vscode-powershell cannot recognize microsoft store installed powershell as well

[Wongboo]

I tried to change "terminal.integrated.shell.windows" as well,but no use

[Softgrider]

This happens since updated to Visual Studio Code Version 1.53.
Uninstall Store Version and install msi Version brings the powershell 7.1.x back

[rjmholt]

The logic to automatically pick up a store installation is here:

vscode-powershell/src/platform.ts

Lines 262 to 290 in 7f0b969

	private findPSCoreMsix({ findPreview }: { findPreview?: boolean } = {}): IPossiblePowerShellExe {
	// We can't proceed if there's no LOCALAPPDATA path
	if (!process.env.LOCALAPPDATA) {
	return null;
	}
	// Find the base directory for MSIX application exe shortcuts
	const msixAppDir = path.join(process.env.LOCALAPPDATA, "Microsoft", "WindowsApps");
	if (!fs.existsSync(msixAppDir)) {
	return null;
	}
	// Define whether we're looking for the preview or the stable
	const { pwshMsixDirRegex, pwshMsixName } = findPreview
	? { pwshMsixDirRegex: PowerShellExeFinder.PwshPreviewMsixRegex, pwshMsixName: "PowerShell Preview (Store)" }
	: { pwshMsixDirRegex: PowerShellExeFinder.PwshMsixRegex, pwshMsixName: "PowerShell (Store)" };
	// We should find only one such application, so return on the first one
	for (const subdir of fs.readdirSync(msixAppDir)) {
	if (pwshMsixDirRegex.test(subdir)) {
	const pwshMsixPath = path.join(msixAppDir, subdir, "pwsh.exe");
	return new PossiblePowerShellExe(pwshMsixPath, pwshMsixName);
	}
	}
	// If we find nothing, return null
	return null;
	}

It's not clear why this would suddenly fail, especially due to a VSCode update (since that shouldn't update anything within the extension itself).

It's also mysterious why giving an explicit absolute path would also fail -- that's effectively a bypass for the PowerShell-finding logic and should work no matter where it's pointed (as long as that's a valid PowerShell executable).

[rjmholt]

So we've now had a second report of this, and I'm wondering if there's a permissions issue or similar going on -- hopefully we can reproduce this locally to investigate

[wjvii]

@rjmholt I can confirm the same behavior here as well.

[rjmholt]

So it looks like this is due to fs.existsSync returning false for symlinks, causing this to be false here:

vscode-powershell/src/platform.ts

Line 494 in ce41617

this.knownToExist = fs.existsSync(this.exePath);

It's not clear why this previously worked, but either node or Windows/the store has changed its behaviour here (our code hasn't changed since we implemented Store PowerShell detection).

We need to update this check to be something like:

try {
    fs.lstatSync(this.exePath);
    this.knownToExist = true;
} catch {
    this.knownToExist = false;
}

Or alternatively do a readlink operation to resolve the link...