Skip to content

ANSI Escape Code received from the SSH from the Linux's BASH breaks the output in the PowerShell Integrated Console #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Sep 3, 2021 · 9 comments
Labels
Area-Extension Terminal Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.

Comments

@ghost
Copy link

ghost commented Sep 3, 2021

.

@ghost ghost added Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed! labels Sep 3, 2021
@andyleejordan
Copy link
Member

VSCode does not recognize this setting. Therefore, I do not provide this log.
Provide Language Server Protocol payload logs: "powershell editor services.trace.server":"verbose"

Hi, while Code won't recognize and highlight it, it's a valid option and enables tracer logs on the server. Please enable this setting and provide these logs. Thanks!

@andyleejordan
Copy link
Member

andyleejordan commented Sep 3, 2021

This result is also empty:

PS C:\Users\michal> $psEditor.EditorServicesVersion
PS C:\Users\michal>

If this is empty it means you're executing in a regular pwsh shell in VS Code, and not in the integrated terminal. Please run it in the integrated terminal instead.

andyleejordan pushed a commit that referenced this issue Sep 7, 2021
…3544)

Add this additional note as VS Code does not recognize this setting. The result is: 'Unknown Configuration Setting'.
#3543 (comment)
@andyleejordan
Copy link
Member

Could you try getting the output of stty for us? Like what @SeeminglyScience describes here: PowerShell/PowerShellEditorServices#1571 (comment)

@SeeminglyScience
Copy link
Collaborator

Could you try getting the output of stty for us? Like what @SeeminglyScience describes here: PowerShell/PowerShellEditorServices#1571 (comment)

I don't have stty on Windows. Therefore, it won't work for me in PowerShell.

Oh I thought you were on linux my bad, not related then. Might be console mode related. There isn't really a quick way to test that like there is for stty though afaik

@andyleejordan
Copy link
Member

Can you confirm this is still reproducing with v2021.9.0? I mean, it probably does, but it'd be helpful to know. Otherwise we're hoping the editor services pipeline work (PowerShell/PowerShellEditorServices#1295) may fix it as it replaces much of our custom console host implementation with re-use of PowerShell's own (which clearly works).

@andyleejordan andyleejordan added Area-Extension Terminal and removed Needs: Triage Maintainer attention needed! labels Sep 9, 2021
@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Sep 10, 2021
@andyleejordan
Copy link
Member

Thought so. We'll have to try to repro it, but also are hopeful the work Rob is doing may fix it. Unfortunately these kinds of issues tend to be the most difficult to fix.

@andyleejordan andyleejordan removed the Needs: Maintainer Attention Maintainer attention needed! label Sep 14, 2021
@andyleejordan
Copy link
Member

Hello, and thank you for your patience! The latest PowerShell Preview for VS Code is now out, and includes the reworking of our pipeline and threading architecture in PowerShell/PowerShellEditorServices#1295. Could you verify if this issue still reproduces using v2021.10.3-preview? Please note that this preview is likely to include other bugs, and you should feel free to file new issues for those so we can work through them. Thanks again!

@andyleejordan andyleejordan added the Needs: Author Feedback Please give us the requested feedback! label Oct 29, 2021
@ghost ghost added Needs: Maintainer Attention Maintainer attention needed! and removed Needs: Author Feedback Please give us the requested feedback! labels Oct 29, 2021
@andyleejordan andyleejordan added Resolution-Fixed Will close automatically. and removed Needs: Maintainer Attention Maintainer attention needed! labels Oct 29, 2021
@andyleejordan
Copy link
Member

Awesome!!

@ghost ghost closed this as completed Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

This issue has been marked as fixed. It has been automatically closed for housekeeping purposes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.
Projects
None yet
Development

No branches or pull requests

2 participants