Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the command that is running in the PowerShell console on the same line #3786

Closed
5 tasks done
PrzemyslawKlys opened this issue Jan 25, 2022 · 5 comments · Fixed by PowerShell/PowerShellEditorServices#1691
Labels
Area-Extension Terminal Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash.

Comments

@PrzemyslawKlys
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.

Summary

I know this is nitpicking but somehow in the new Preview I dislike that it shows the execution on the next line rather than on same line:

image

Production:

image

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.22000.282
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22000.282
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Visual Studio Code Version

1.63.2
899d46d82c4c95423fb7e10e68eba52050e30ba3
x64

Extension Version

ironmansoftware.powershell-universal@2.5.0
ms-vscode.powershell@2021.12.0
ms-vscode.powershell-preview@2022.1.1
tobysmith568.run-in-powershell@1.1.1
TylerLeonhardt.vscode-inline-values-powershell@0.0.5

Steps to Reproduce

Run code with F5

Visuals

No response

Logs

No response

@PrzemyslawKlys PrzemyslawKlys added the Issue-Bug A bug to squash. label Jan 25, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jan 25, 2022
@PrzemyslawKlys PrzemyslawKlys changed the title Do not display the command that is running in the PowerShell console Display the command that is running in the PowerShell console on the same line Jan 25, 2022
@JustinGrote
Copy link
Collaborator

Thanks for raising! It is a change in behavior and can be jarring to users so I think it's a valid ask. There's a couple other related issues e.g. debug doesn't issue newline after prompt

@JustinGrote JustinGrote added Area-Extension Terminal Bug: Pre-release Bugs reproducing only in the pre-release extension. and removed Needs: Triage Maintainer attention needed! labels Jan 25, 2022
@andyleejordan
Copy link
Member

Yeah there's a lot of work around redisplaying the prompt properly that we need to do! This is definitely valid and thank you for reporting.

@andyleejordan
Copy link
Member

I'm looking at this, but I'm not sure how addressable it is. Technically when running a script via F5 or arbitrary selected code via F8, we cancel the current prompt and just run the code...so it is explicitly not running on that prompt but entirely separately. Note that if you add anything to that prompt but don't hit enter, and then hit F8, everything at the prompt is thrown away instead. So what it's currently displaying is more accurate. That said, I think we could re-render the prompt in front of the command we're about to run.

@andyleejordan andyleejordan moved this from Todo to In Progress in Sea Biscuit Feb 1, 2022
@PrzemyslawKlys
Copy link
Contributor Author

That sounds good. Btw I have a lot of issues around the display (clear-host helping partially) where the text goes over text, and even new lines stop working under debugging. Should I create separate issues or update it here?

@andyleejordan
Copy link
Member

Let's see how much PowerShell/PowerShellEditorServices#1690 and PowerShell/PowerShellEditorServices#1691 help out with that. I'll get a new Preview out soon, and then for any more problems yes please new issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants