Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server startup errors without a stack trace should not keep terminal open #572

Closed
Bill-Stewart opened this issue Mar 16, 2017 · 10 comments
Labels
Issue-Bug A bug to squash.

Comments

@Bill-Stewart
Copy link

Bill-Stewart commented Mar 16, 2017

Still giving an error when using PowerShell 2.0. Information box says:

Error  Could not start language service:

Log data:

powershell.exe started --
    pid: 544
    exe: C:\Windows\Sysnative\WindowsPowerShell\v1.0\powershell.exe
    args: C:\Users\<username>\.vscode\extensions\ms-vscode.PowerShell-0.10.0\scripts\Start-EditorServices.ps1 -EditorServicesVersion '0.10.0' -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '0.10.0' -BundledModulesPath 'C:\Users\<username>\.vscode\extensions\ms-vscode.PowerShell-0.10.0\modules' -EnableConsoleRepl -LogLevel 'Normal' -LogPath 'C:\Users\<username>\.vscode\extensions\ms-vscode.PowerShell-0.10.0\logs\1489695383-e4f9b666-4c44-4c37-819c-6f08c3b1a0671489695377337\EditorServices.log' -SessionDetailsPath 'C:\Users\<username>\.vscode\extensions\ms-vscode.PowerShell-0.10.0\sessions\PSES-VSCode-31532' 

powershell.exe terminated or terminal UI was closed

Could not start language service: 
Timed out waiting for session file to appear.
@daviwil
Copy link
Contributor

daviwil commented Mar 16, 2017

You're a little ahead of me :) I just shipped 0.10.1 with the fix for this, let me know if it's fixed for you now.

@daviwil
Copy link
Contributor

daviwil commented Mar 17, 2017

Going to close this now since it should be fixed, if you find that it's not I am happy to reopen it :)

@daviwil daviwil closed this as completed Mar 17, 2017
@Bill-Stewart
Copy link
Author

Thanks!

Is there any way to hide the error info box, though?

@daviwil
Copy link
Contributor

daviwil commented Mar 17, 2017

Which one, the one at the top of the screen, or the box at the bottom which would have been the integrated console? If the one at the bottom, I will make that one go away automatically in cases where there's no error message to be copied.

@daviwil daviwil reopened this Mar 17, 2017
@daviwil daviwil changed the title Error Could not start language service: Language server startup errors without a stack trace should not keep terminal open Mar 17, 2017
@daviwil daviwil added the Issue-Bug A bug to squash. label Mar 17, 2017
@daviwil daviwil added this to the 0.10.2 milestone Mar 17, 2017
@Bill-Stewart
Copy link
Author

The error box at the top of the screen:

image

Displaying it once is fine, but it would be nice to be able to disable this message.

The "initialization error" at the bottom also persists. Perhaps a single option could disable both? Or have an option that enables the language highlighter only?

@daviwil
Copy link
Contributor

daviwil commented Mar 17, 2017

Yep, good point. I think I'll add a new setting to disable the language server completely, that would prevent you from ever seeing that error again. Someone else just asked for that feature in #580 so I'll fix that there.

@daviwil daviwil modified the milestones: 0.10.2, Next Patch Update Mar 24, 2017
@daviwil daviwil modified the milestones: Next Patch Update, Next Feature Update Apr 6, 2017
@daviwil daviwil modified the milestones: April 2017, May 2017 May 8, 2017
@daviwil daviwil modified the milestones: May 2017, July 2017 Jun 1, 2017
@zhoufwind
Copy link

zhoufwind commented Jun 9, 2017

Hi, still got this error all the time, looking forward to hide it, thanks!

[11:45:18] Language server starting...
powershell.exe started --
pid: 8078
exe: /usr/local/bin/powershell
args: /Users/<username>/.vscode/extensions/ms-vscode.powershell-1.2.1/scripts/Start-EditorServices.ps1 -EditorServicesVersion '1.2.1' -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '1.2.1' -BundledModulesPath '/Users/zhoufeng/.vscode/extensions/ms-vscode.powershell-1.2.1/modules' -EnableConsoleRepl -LogLevel 'Normal' -LogPath '/Users/<username>/.vscode/extensions/ms-vscode.powershell-1.2.1/logs/1496979918-009b2400-1b81-4659-a41e-04cda0ee56f41496979900311/EditorServices.log' -SessionDetailsPath '/Users/<username>/.vscode/extensions/ms-vscode.powershell-1.2.1/sessions/PSES-VSCode-563-237610' -FeatureFlags @()

[11:46:18] Language server startup failed.
Could not start language service:
Timed out waiting for session file to appear.

powershell.exe terminated or terminal UI was closed

@daviwil
Copy link
Contributor

daviwil commented Jun 12, 2017

@zhoufwind do you have any additional logs that might indicate what issue you are experiencing? Follow these steps and see if an EditorServices.log file gets created:

https://github.com/PowerShell/vscode-powershell#reporting-problems

@pythoninthegrass
Copy link

pythoninthegrass commented Jun 19, 2017

Hi @daviwil. I emailed you my logs from my Napster work address. I'll be happy to help test with whatever you'd like to try. Also, forgot to mention my environment is OS X 10.10.5, VSCode 1.13.1.

Thanks for your help!

EDIT 6-22-17
Turns out, I was running the Alpha 15 version. Had to upgrade from OS X 10.10 to 10.12 then install v6.0.0-beta.2. The PowerShell integrated console is running like a champ.

@daviwil daviwil modified the milestones: July 2017, Future Oct 26, 2017
@TylerLeonhardt TylerLeonhardt modified the milestone: Future May 24, 2018
@TylerLeonhardt
Copy link
Member

The whole point of the PowerShell extension is the language server... so I'm going to go ahead and close this.

I think we've come a long way since the original issue was opened. If there's anything else in this thread that you'd like to see still, let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

5 participants