-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting to disable auto-loading of Integrated Terminal #580
Comments
Absolutely, I can add this. Thanks for the detailed explanation of your situation, also. I was planning on adding a setting for this but I hadn't considered the case where you didn't even want PowerShell to be started for performance reasons (even if the terminal wasn't shown automatically). I wonder if it makes sense to have 2 options:
What do you think? |
I agree with @The-New-Guy and the changed behavior of opening the integrated terminal upon VSCode startup. I would be in favor of the What impact would there be if you were to set |
Yep, IntelliSense, symbol navigation, code formatting, pretty much anything that's not syntax highlighting. |
@daviwil I think the two options you mentioned would work wonderfully in my scenario. Thanks. |
Just wanted to throw in my 2 cents and say that |
I'll ship an update in the next couple of days with these settings. |
Came to the repo searching for some issue related to new auto-start terminal. VS Code already has a built-in terminal, which I have configured to launch powershell. I don't want another random powershell terminal, which doesn't load my Do I understand correctly that with the latest fix, if I disable the auto-start terminal I lose most of the features of the plugin? i.e. "IntelliSense, symbol navigation, code formatting, pretty much anything that's not syntax highlighting" That is extremely unfortunate - this extension was functioning quite well in the past without opening extra terminals... If the behavior could be changed (or made configurable) such that the auto-start terminal launches "silently" (doesn't cause anything to appear at the bottom, doesn't take focus, not visible at all) then I would be content enough, because I'd never have to see it. |
The change I made adds two new settings:
Are the descriptions there sufficient to indicate that you can enable language features without having the integrated console show by default? If not, do you have any recommendation on how I can make it clearer? Your desired behavior is supported with these settings, I just want to make sure users will understand that when they read the setting names and descriptions. Regarding the new console, it does load your profile, just not the same one as powershell.exe: |
ah, so code will have its own profile the same as the ise does. very good idea @daviwil !! |
Ah, I did not realize |
Cool! Glad to hear it. I'll have a new update out tomorrow with these settings added. |
Just release 0.11.0, check it out and let me know what you think! |
@daviwil This is exactly what I was looking for. Thank you very much! |
Awesome, thanks a lot for trying it out! |
Hey @daviwil what to do make your changes work for me? |
@sourabhranka to not start the PowerShell extension automatically, simply go to your settings in vscode and search for Keep in mind, you'll loose out on all of the features: IntelliSense, code navigation, integrated console, code formatting, etc until you run: |
This new Integrated Terminal is a great feature. I foresee myself using it a lot in the future. That said, I'm wondering if it would be possible to put in a setting that disables the automatic loading of this terminal when opening PowerShell files. Of course you would also need to a way to load it on demand later.
The VSCode startup process has been getting faster and faster in months past and as such I have started using it to quickly view files instead of Notepad++. I will simply right-click and "Open in VSCode" to quickly take a peak at some script file. However, with this new integrated terminal this now complicates things.
I realize that for most people the loading of the user's PowerShell profile probably doesn't take but a couple seconds to load. However, as a system admin for Lync, Exchange, AD and several others, my profile connects to each of those services and imports a session. This process takes considerable time which is fine on most occasions, however when taking a quick look at a file it can be hindrance.
This is further exasperated by the fact that when the PowerShell extension opens the terminal panel, the VSCode integrated terminal which is also PowerShell will also start loading my profile. So each time I go to quickly view a file I have two separate powershell terminals starting up, each taking considerable time to load all of the imported sessions in my profile.
I could just remove the import of the sessions from the vscode specific powershell profile but if I were to do that I would likely never even use it since 99% of all my development is against these remote services and therefore I need these sessions during my development. I could also just ignore this, hit
Ctrl + `
to hide the terminal and close out whenever I'm ready. However, while that most likely won't cause an issue to close out while these sessions are in the middle of an import, it can be problematic if you are doing this repeatedly for several files in a row.This was also an issue for me in the ISE days. Back when I used to use ISE for everything, I had actually written a PowerShell command, Open-ClipboardFile (with alias ofc), that allowed me to copy a file in Windows Explorer and then open that file in my currently open ISE editor (which ran as a different user than my login user). That way I wasn't loading a new instance of ISE (and thus all of my remote sessions) every time I wanted to quickly look at a file.
The text was updated successfully, but these errors were encountered: