Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Terminal captures return key presses as history items #618

Closed
AspenForester opened this issue Mar 24, 2017 · 1 comment
Closed
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@AspenForester
Copy link
Contributor

System Details

PS C:\Users\me> code -v
1.10.2
8076a19fdcab7e1fc1707952d652f0bb6c6db331
PS C:\Users\me>
PS C:\Users\me> $pseditor.EditorServicesVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
0      11     0      0


PS C:\Users\me>
PS C:\Users\me> code --list-extensions --show-versions
ms-vscode.PowerShell@0.11.0
PS C:\Users\me>
PS C:\Users\me> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.0.10586.117
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.117
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

Hitting the return key preceded by no other entry results in the history being incremented, and arrowing back to the last executed command requires arrowing up through each of your return hits.

Attached Logs

PS C:\Users\me> get-history

  Id CommandLine
  -- -----------
   1 gci


PS C:\Users\me> get-history

  Id CommandLine
  -- -----------
   1 gci
   2 get-history


PS C:\Users\me>
PS C:\Users\me>
PS C:\Users\me>
PS C:\Users\me> get-history

  Id CommandLine
  -- -----------
   1 gci
   2 get-history
   3 get-history
   4
   5
   6


PS C:\Users\me>
@daviwil
Copy link
Contributor

daviwil commented Mar 24, 2017

Thanks! Will get this fixed soon.

@daviwil daviwil added this to the 0.11.1 milestone Mar 24, 2017
@daviwil daviwil added the Issue-Bug A bug to squash. label Mar 24, 2017
@daviwil daviwil modified the milestones: Next Patch Update, Next Feature Update Apr 6, 2017
daviwil added a commit to daviwil/PowerShellEditorServices that referenced this issue Apr 25, 2017
This change fixes PowerShell/vscode-powershell#618 which reports that
empty input lines are being added to command history in the integrated
console.  This change updates the command input logic to skip sending
empty lines to the command executor.
@daviwil daviwil modified the milestones: April 2017, 1.0.0-beta1, 1.0.0 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants