Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching between PowerShell versions on Windows is unreliable #737

Closed
daviwil opened this issue May 12, 2017 · 2 comments
Closed

Switching between PowerShell versions on Windows is unreliable #737

daviwil opened this issue May 12, 2017 · 2 comments
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented May 12, 2017

It appears that after the latest upgrade to vscode-languageserver we've lost the ability to switch between PowerShell versions cleanly using the status bar menu. Sometimes it hangs at startup causing the extension host to crash after a timeout. Other times it seems to work fine. There must be some initialization step that we need to clean up when using the newer version of that library.

/cc @jpsnover

@daviwil daviwil added this to the May 2017 milestone May 12, 2017
@csandfeld
Copy link

For me the integrated console hangs when I run the "PowerShell: Restart Current Session" command. Not sure if that is related, or if it should be logged as an issue of its own.

@daviwil
Copy link
Contributor Author

daviwil commented May 19, 2017

I think it's the same issue, I'll look into it today.

@daviwil daviwil modified the milestones: 1.2.0, May 2017 May 24, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 26, 2017
This change fixes some issues with switching and restarting the active
PowerShell session after our migration to the new vscode-languageclient
package.  They changed their error handling code in a way that caused
our shutdown process to get stuck in a loop.

Fixes PowerShell#737
Fixes PowerShell#782
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 30, 2017
This change fixes some issues with switching and restarting the active
PowerShell session after our migration to the new vscode-languageclient
package.  They changed their error handling code in a way that caused
our shutdown process to get stuck in a loop.

Fixes PowerShell#737
Fixes PowerShell#782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants