Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybinding for PowerShellFindModule (ctrl+k ctrl+f) conflicts with vscode defaults #751

Closed
ajansveld opened this issue May 17, 2017 · 1 comment
Closed

Keybinding for PowerShellFindModule (ctrl+k ctrl+f) conflicts with vscode defaults #751

ajansveld opened this issue May 17, 2017 · 1 comment
Labels
Issue-Bug A bug to squash.
Milestone
1.1.0

Comments

@ajansveld
Copy link

System Details

  • Operating system name and version: Windows 10
  • VS Code version: 1.12.2
  • PowerShell extension version: 1.0.0
  • Output from $PSVersionTable:
Name                           Value
----                           -----
PSVersion                      5.1.14393.1198
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.1198
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

When using the default keyboard shortcut for Format Selection (ctrl+k ctrl+f) in a PowerShell script with selected text, the PowerShellFindModule action launches instead.

Suggest removing the keybinding for PowerShellFindModule or setting it to an unused key combination (e.g. ctrl+k ctrl+n) in package.json.
@daviwil
Copy link
Contributor

daviwil commented May 17, 2017

Great point, I'll change that! This action probably shouldn't even have a keybinding since it's not something that would be used very frequently.

@daviwil daviwil added this to the 1.1.0 milestone May 17, 2017
@daviwil daviwil added Area-General Issue-Bug A bug to squash. labels May 17, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 17, 2017
@daviwil
Fix PowerShell#751: Remove keybinding for PowerShellFindModule command
446e2e3 
This command's keybinding conflicts with VS Code's default key binding
for the Format Selection command.  The PowerShellFindModule command
isn't commonly used so we are just removing the binding instead of
finding a different one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug A bug to squash.
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@daviwil @ajansveld